-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Vendor mamba.api
#1372
MAINT: Vendor mamba.api
#1372
Conversation
if this helps resolve the challenges with context not being initialized correctly that is great! I will say that now that conda-libmamba-solver has been deployed, there is little advantage of using "mamba", and you may want to just "avoid churn". Thanks for keeping this project working all these years! |
That bug-fix is next, this is to get the
I understand
Glad its still in use! (though I'm a relatively new maintainer, 7-8 months tops I guess). |
Draft for a bit, the plugin is still rather fragile (the most compatible way to use it seems to be to keep Otherwise (without
|
Should be good to go now. Works with only |
The upstream issue says, in justifying removing the API functions:
and
It seems some of the functionality here should be reported upstream as missing, so that we can get rid of the helper class eventually. |
Is there a test that was failing before this PR and now passes? I don't see any test changes. |
f674e14
to
231f18d
Compare
231f18d
to
6a2af5c
Compare
My reading of that was just that the API functionality needed (also in |
I hadn't written a CI test for |
111fa2e
to
63b12fb
Compare
Thanks @HaoZeke. mamba test is passing |
Closes #1353. Also addresses comments in #1370. There's an upstream clarification issue in mamba-org/mamba#3159. However, I think this makes sense to go in as-is. Will cut a release soon with the fix.