-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#6307] feat(flink): remove log4j from Gravitino Flink connector #6308
Conversation
@coolderli @jerryshao PTAL |
Have you identified the root cause of this issue? Does it work with 0.7.0-inbucating? |
yes, it works with 0.7.0-inbucating |
So I suggest we may need to find out which commit introduced the problem and make the necessary changes accordingly. |
I don' think so, it's reasonable to remove log4j from the Flink runtime jar to avoid the conflict. |
I don't deny this |
we didn't upgrade log4j version for one year, seems not the commit in Gravitino introduce this problems. I guess the new package changes the sequence of the classes loaded by Flink classloader introduce this problem. |
### What changes were proposed in this pull request? remove log4j from Gravitino Flink connector ### Why are the changes needed? Fix: #6307 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? setup an local flink cluster, run flink SQL
What changes were proposed in this pull request?
remove log4j from Gravitino Flink connector
Why are the changes needed?
Fix: #6307
Does this PR introduce any user-facing change?
no
How was this patch tested?
setup an local flink cluster, run flink SQL