Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file matching to PR generator #19678

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

aburan28
Copy link
Contributor

@aburan28 aburan28 commented Aug 24, 2024

This pull request adds the ability to filter PRs based on whether or not they contain a certain file/directory using regular expressions in the pull request generator. Currently this only supports Github/Gitea/Gitlab only.

This adds a fileMatch parameter to the pull request generator.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@aburan28 aburan28 requested a review from a team as a code owner August 24, 2024 17:25
Copy link

bunnyshell bot commented Aug 24, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link

bunnyshell bot commented Aug 24, 2024

✅ Preview Environment created on Bunnyshell but will not be auto-deployed

See: Environment Details

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@aburan28 aburan28 changed the title add file matching to PR generator feat: add file matching to PR generator Aug 24, 2024
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first-time PR!

Before we move forward, I think we need documentation explaining how to use the feature added and it would be good in the PR if you can explain the feature aswell.

Thanks!

Signed-off-by: Adam Buran <[email protected]>
@aburan28 aburan28 requested a review from a team as a code owner September 5, 2024 14:41
Signed-off-by: Adam Buran <[email protected]>
Signed-off-by: Adam Buran <[email protected]>
@aburan28
Copy link
Contributor Author

@todaywasawesome updated with documentation

crenshaw-dev added a commit to crenshaw-dev/argo-cd that referenced this pull request Dec 18, 2024
Signed-off-by: aburan28 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants