Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TrackedObjectKinematics instead of DetectedObjectKinematics for TrackedObject & object #9549

Closed
3 tasks done
felixf4xu opened this issue Dec 3, 2024 · 1 comment
Closed
3 tasks done

Comments

@felixf4xu
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

In autoware, there are 2 kinds of ObjectKinematics definition, one is TrackedObjectKinematics and the other is DetectedObjectKinematics, they are equal to each other in integer value, but they should have difference namespaces.__

Expected behavior

void MapBasedPredictionNode::updateObjectData(TrackedObject & object)
{
  std::unique_ptr<ScopedTimeTrack> st_ptr;
  if (time_keeper_) st_ptr = std::make_unique<ScopedTimeTrack>(__func__, *time_keeper_);


  if (
    object.kinematics.orientation_availability ==
    autoware_perception_msgs::msg::DetectedObjectKinematics::AVAILABLE) {
    return;
  }

DetectedObjectKinematics is a wrong type, it should be TrackedObjectKinematics because of code type TrackedObject & object

for same reason,
code

 switch (object.kinematics.orientation_availability) {
    case autoware_perception_msgs::msg::DetectedObjectKinematics::SIGN_UNKNOWN: {

should also use TrackedObjectKinematics

Actual behavior

DetectedObjectKinematics is used for TrackedObject type.

Steps to reproduce

check source code, code review.

Versions

autoware, latest main branch

Possible causes

No response

Additional context

No response

@amadeuszsz
Copy link
Contributor

@felixf4xu good catch & thank you for your report! Addressed in #9553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants