Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_behavior_path_planner_common): add continuous curvature pullover path generation #10045

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

TakumIto
Copy link
Contributor

@TakumIto TakumIto commented Jan 29, 2025

Description

Append continuous curvature pullover path generation feature using clothoid curve.
Supporting only the forward pullover for now.

Behavior comparison
Clothoid (Developed in this PR)

forward_clothoid.webm

Shift parking (Default)

forward_shift.webm

Max steering

forward_suegiri.webm

Related links

Related research paper
https://ieeexplore.ieee.org/document/6871412
https://ieeexplore.ieee.org/document/6856443

Launcher
autowarefoundation/autoware_launch#1320
Parent Issue:

  • N/A

How was this PR tested?

evaluator
https://evaluation.tier4.jp/evaluation/reports/c9a0571a-c807-5888-8e76-c757cf1948a3?project_id=prd_jt

(legacy test before commit c929579)
https://evaluation.tier4.jp/evaluation/reports/e3854d38-70eb-55f5-bed7-a43fdc94140f?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jan 29, 2025
Copy link

github-actions bot commented Jan 29, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55
Copy link
Contributor

kosuke55 commented Jan 30, 2025

@TakumIto
could you drop unnecessary comit?
tier4#1776
currently there are diff between awf:main and tier4:awf-latest so need to drop it when sending PR to awf

@kosuke55
Copy link
Contributor

maybe missing goal/start_planner_module update commit?

std::reverse(p.lane_ids.begin(), p.lane_ids.end());
}

if (theta != 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theta is double and may have floating point error
so better not use exact 0
like

if (theta < eps)

@kosuke55
Copy link
Contributor

if now we can use one of arc or clothoid, prepare parameters for enabling each.

  • enable_arc_forward_parking: true
  • enable_clothoid_forward_parking: true
     } else if (planner_type == "ARC_FORWARD" && parameters.enable_arc_forward_parking) {
      pull_over_planners_.push_back(
        std::make_shared<GeometricPullOver>(node, parameters, /*is_forward*/ true, /*use_clothoid*/ false));
    } else if (planner_type == "CLOTHOID_FORWARD" && parameters.enable_clothoid_forward_parking) {
      pull_over_planners_.push_back(
        std::make_shared<GeometricPullOver>(node, parameters, /*is_forward*/ true, /*use_clothoid*/ true));

@TakumIto TakumIto force-pushed the feat/clothoid_forward_parking branch from 7d28e5a to a3dfbda Compare January 31, 2025 03:05
Takumi Ito added 3 commits January 30, 2025 22:06
@TakumIto TakumIto force-pushed the feat/clothoid_forward_parking branch from a3dfbda to 2e2148f Compare January 31, 2025 03:08
@github-actions github-actions bot removed the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jan 31, 2025
@TakumIto TakumIto force-pushed the feat/clothoid_forward_parking branch from 2e2148f to fd5865d Compare January 31, 2025 03:11
Signed-off-by: Takumi Ito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

2 participants