feat(autoware_tensorrt_yolox): add schema for autoware_tensorrt_yolox #10047
+156
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vish0012 <[email protected]>
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
ktro2828
changed the title
ktro2828
reviewed
Jan 30, 2025
| "maximum": 1.0, | ||
| "description": "A threshold value of existence probability score, all of objects with score less than this threshold are ignored." | ||
| "description": "Threshold for object existence probability. Objects with scores below this value are ignored.", | ||
| "default": 0.35 |
There was a problem hiding this comment.
[Q] Why did you remove min and max values?
| "maximum": 1.0, | ||
| "description": "A threshold value of NMS." | ||
| "description": "Threshold value for Non-Maximum Suppression (NMS).", | ||
| "default": 0.7 |
There was a problem hiding this comment.
[Q] Why did you remove min and max values?
ktro2828
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10047 +/- ##
=======================================
Coverage 29.76% 29.76%
=======================================
Files 1444 1444
Lines 108686 108681 -5
Branches 42664 42665 +1
=======================================
Hits 32352 32352
+ Misses 73150 73145 -5
Partials 3184 3184
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the autoware_tensorrt_yolox package.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.