Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_traffic_light_classifier): add traffic light classifier schema, README and car and ped launcher #10048

Conversation

vish0012
Copy link
Contributor

@vish0012 vish0012 commented Jan 30, 2025

Description

Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the autoware_traffic_light_classifier package.

  • create json schema
  • update readme file
  • add launch file car and pedestrian

Related links

Parent Issue:

  • Link

How was this PR tested?

  • colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release --packages-up-to autoware_traffic_light_classifier
  • ros2 launch launch/autoware_traffic_light_classifier.launch.xml

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Jan 30, 2025
Copy link

github-actions bot commented Jan 30, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@MasatoSaeki MasatoSaeki changed the title feat(autoware_traffic_light_classifier):Add traffic light classifier schema and README feat(autoware_traffic_light_classifier):add traffic light classifier schema and README Feb 4, 2025
@MasatoSaeki MasatoSaeki added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Feb 4, 2025
@MasatoSaeki MasatoSaeki changed the title feat(autoware_traffic_light_classifier):add traffic light classifier schema and README feat(autoware_traffic_light_classifier): add traffic light classifier schema and README Feb 5, 2025
@MasatoSaeki MasatoSaeki changed the title feat(autoware_traffic_light_classifier): add traffic light classifier schema and README feat(autoware_traffic_light_classifier): add traffic light classifier schema, README and car and ped launcher Feb 5, 2025
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Feb 5, 2025
@MasatoSaeki MasatoSaeki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 5, 2025
Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I checked DLR on my local pc
(I added car and pedestrian launcher, you do not have to mind.)

Signed-off-by: MasatoSaeki <[email protected]>
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 28.29%. Comparing base (768f2ca) to head (ef857dc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...light_classifier/src/classifier/cnn_classifier.cpp 0.00% 6 Missing ⚠️
...t_classifier/src/traffic_light_classifier_node.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10048   +/-   ##
=======================================
  Coverage   28.29%   28.29%           
=======================================
  Files        1484     1484           
  Lines      111090   111090           
  Branches    43151    43153    +2     
=======================================
  Hits        31434    31434           
  Misses      76638    76638           
  Partials     3018     3018           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 28.29% <ø> (+<0.01%) ⬆️ Carriedforward from 674c880

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MasatoSaeki MasatoSaeki merged commit 8389fd0 into autowarefoundation:main Feb 5, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants