feat(goal_planner): do not use isActivated() in deciding state transition

[soblin]

Description

goal_planner sends updateRTCStatus if it was able to find a stable safe path from the generated candidates (DECIDED status), and before updateRTCStatus isActivated() is null because goal_planner RTC entry itself does not exist. And after updateRTCStatus goal_planner RTC entry begins to exist but it remains DECIDED forever, so isActivated() in transit_state does not make sense at all by definition.

depends #10052

Related links

Parent Issue:

• Link

How was this PR tested?

• https://evaluation.tier4.jp/evaluation/reports/f5b3c49c-2065-53bb-b091-5e4261a9a83c?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 28.27%. Comparing base (ffded51) to head (cef6775).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
...or_path_goal_planner_module/src/decision_state.cpp	0.00%	4 Missing ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10056      +/-   ##
==========================================
- Coverage   28.28%   28.27%   -0.01%     
==========================================
  Files        1484     1487       +3     
  Lines      111101   111138      +37     
  Branches    43170    43155      -15     
==========================================
  Hits        31426    31426              
- Misses      76657    76693      +36     
- Partials     3018     3019       +1     

Flag	Coverage Δ		*Carryforward flag
differential	0.50% <0.00%> (?)
total	28.31% <ø> (+0.02%)	⬆️	Carriedforward from ffded51

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.