fix(motion_velocity_planner_common): fix the calc_possible_min_dist_from_obj_to_traj_poly calculation #10059
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
takayuki5168
added
the
run:build-and-test-differential
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10059 +/- ##
==========================================
- Coverage 28.29% 28.29% -0.01%
==========================================
Files 1484 1487 +3
Lines 111088 111116 +28
Branches 43149 43149
==========================================
+ Hits 31437 31439 +2
- Misses 76632 76660 +28
+ Partials 3019 3017 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
takayuki5168
force-pushed
the
fix/motion-velocity-calc_possible_min_dist_from_obj_to_traj_poly
branch
from
644c548 to
0c4bcd6
Compare
takayuki5168
force-pushed
the
fix/motion-velocity-calc_possible_min_dist_from_obj_to_traj_poly
branch
from
0c4bcd6 to
1f3c60b
Compare
maxime-clem
approved these changes
Feb 3, 2025
yuki-takagi-66
approved these changes
Feb 3, 2025
takayuki5168
force-pushed
the
fix/motion-velocity-calc_possible_min_dist_from_obj_to_traj_poly
branch
from
1f3c60b to
97773ff
Compare
takayuki5168
requested review from
soblin,
satoshi-ota,
shmpwk and
tkimura4
as code owners
github-actions
bot
added
the
type:ci
…rom_obj_to_traj_poly calculation Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
takayuki5168
force-pushed
the
fix/motion-velocity-calc_possible_min_dist_from_obj_to_traj_poly
branch
from
97773ff to
fedc6f2
Compare
github-actions
bot
removed
the
type:ci
takayuki5168
deleted the
fix/motion-velocity-calc_possible_min_dist_from_obj_to_traj_poly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The calculation of calc_possible_min_dist_from_obj_to_traj_poly was wrong, and this PR fixed the issue.
Related links
How was this PR tested?
planning simulator & scenario tests
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.