feat(autoware_pointcloud_preprocessor): reuse collectors to reduce creation of collector and timer #10074
+143
−40
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Feb 5, 2025 in 53s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: +0.05 (8.01 -> 8.06)
- Declining Code Health: 1 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method concatenate_and_time_sync_node.cpp: PointCloudConcatenateDataSynchronizerComponent::cloud_callback
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
PointCloudConcatenateDataSynchronizerComponent::cloud_callback increases in cyclomatic complexity from 9 to 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Bumpy Road Ahead
PointCloudConcatenateDataSynchronizerComponent::cloud_callback increases from 2 to 3 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 5.73 to 6.09, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Loading