Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_pointcloud_preprocessor): fix potential double unlock in concatenate node #10082

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Feb 7, 2025

Description

This PR resolves a potential double unlock issue in the concatenate node. Previously, under certain conditions, the mutex could be unlocked twice, leading to undefined behavior and potential segmentation faults.

Related links

Note: This PR needs to rebase after #10074 is merged.

Parent Issue:

  • Link

How was this PR tested?

  • Tested with unit test.
  • Tested with sample rosbag

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@vividf vividf requested a review from mojomex February 7, 2025 04:34
@vividf vividf self-assigned this Feb 7, 2025
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@vividf vividf added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 62.06897% with 22 lines in your changes missing coverage. Please review.

Project coverage is 28.32%. Comparing base (bd84834) to head (d8c5033).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...processor/src/concatenate_data/cloud_collector.cpp 55.88% 8 Missing and 7 partials ⚠️
...oncatenate_data/concatenate_and_time_sync_node.cpp 70.83% 2 Missing and 5 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10082   +/-   ##
=======================================
  Coverage   28.32%   28.32%           
=======================================
  Files        1485     1486    +1     
  Lines      111090   111153   +63     
  Branches    43150    43171   +21     
=======================================
+ Hits        31466    31488   +22     
- Misses      76603    76640   +37     
- Partials     3021     3025    +4     
Flag Coverage Δ *Carryforward flag
differential 22.87% <62.06%> (?)
differential-cuda 20.64% <62.06%> (?)
total 28.31% <ø> (-0.02%) ⬇️ Carriedforward from 2f0ff33

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant