Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pointcloud_preprocessor): add Max to codeowners #10083

Conversation

mojomex
Copy link
Contributor

@mojomex mojomex commented Feb 7, 2025

Description

Add myself to pointcloud_preprocessor codeowners.

@mojomex mojomex requested a review from amadeuszsz February 7, 2025 05:10
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Feb 7, 2025
@mojomex mojomex requested a review from vividf February 7, 2025 05:10
Copy link

github-actions bot commented Feb 7, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mojomex mojomex requested review from drwnz and knzo25 February 7, 2025 05:11
@mojomex mojomex force-pushed the chore/sneak-max-into-pointcloud-preprocessor-codeowners branch from dd72aaa to cefb256 Compare February 7, 2025 05:16
@github-actions github-actions bot added component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) and removed type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Feb 7, 2025
@mojomex mojomex added the tag:update-codeowners-from-packages Mark for codeowners update workflow. (auto-assigned) label Feb 7, 2025
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@mojomex mojomex enabled auto-merge (squash) February 7, 2025 05:28
@mojomex mojomex added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 7, 2025
Copy link
Contributor

@vividf vividf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.31%. Comparing base (08b007c) to head (cefb256).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10083      +/-   ##
==========================================
- Coverage   28.31%   28.31%   -0.01%     
==========================================
  Files        1485     1486       +1     
  Lines      111087   111118      +31     
  Branches    43149    43151       +2     
==========================================
+ Hits        31458    31461       +3     
- Misses      76608    76636      +28     
  Partials     3021     3021              
Flag Coverage Δ *Carryforward flag
differential 22.76% <ø> (?)
differential-cuda 20.52% <ø> (?)
total 28.31% <ø> (+<0.01%) ⬆️ Carriedforward from 08b007c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mojomex mojomex merged commit 03d64a8 into autowarefoundation:main Feb 7, 2025
56 of 58 checks passed
@mojomex mojomex deleted the chore/sneak-max-into-pointcloud-preprocessor-codeowners branch February 7, 2025 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:update-codeowners-from-packages Mark for codeowners update workflow. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants