Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_traffic_light_selector): add camera_info into message_filter #10089

Merged

Conversation

MasatoSaeki
Copy link
Contributor

@MasatoSaeki MasatoSaeki commented Feb 10, 2025

Description

add camera_info into message_filter.
If we do not add it, have to handle with mutex to be thread safe. And subscribe topics have same timestamp, So It is efficienfy to subscribe together.

Related links

Parent Issue:

  • Link

How was this PR tested?

I checked this PR on my local PC and merging below PR.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: MasatoSaeki <[email protected]>
@MasatoSaeki MasatoSaeki marked this pull request as ready for review February 10, 2025 08:49
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 10, 2025
Copy link

github-actions bot commented Feb 10, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@MasatoSaeki MasatoSaeki changed the title fix(autoware_traffic_light_selector): add mutex fix(autoware_traffic_light_selector): add camera_info into message_filter Feb 11, 2025
Signed-off-by: MasatoSaeki <[email protected]>
@MasatoSaeki MasatoSaeki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 11, 2025
@MasatoSaeki MasatoSaeki requested a review from YoshiRi February 11, 2025 04:14
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 28.25%. Comparing base (4823597) to head (7a9596a).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...light_selector/src/traffic_light_selector_node.cpp 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10089      +/-   ##
==========================================
- Coverage   28.25%   28.25%   -0.01%     
==========================================
  Files        1488     1488              
  Lines      111261   111265       +4     
  Branches    43141    43140       -1     
==========================================
  Hits        31434    31434              
- Misses      76623    76627       +4     
  Partials     3204     3204              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 28.25% <ø> (+<0.01%) ⬆️ Carriedforward from bff9d40

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MasatoSaeki MasatoSaeki merged commit 2d0ed6f into autowarefoundation:main Feb 12, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants