-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autoware_traffic_light_selector): add camera_info into message_filter #10089
fix(autoware_traffic_light_selector): add camera_info into message_filter #10089
Conversation
Signed-off-by: MasatoSaeki <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: MasatoSaeki <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10089 +/- ##
==========================================
- Coverage 28.25% 28.25% -0.01%
==========================================
Files 1488 1488
Lines 111261 111265 +4
Branches 43141 43140 -1
==========================================
Hits 31434 31434
- Misses 76623 76627 +4
Partials 3204 3204
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
add camera_info into message_filter.
If we do not add it, have to handle with mutex to be thread safe. And subscribe topics have same timestamp, So It is efficienfy to subscribe together.
Related links
Parent Issue:
How was this PR tested?
I checked this PR on my local PC and merging below PR.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.