Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoware_motion_utils)!: port to autoware.core/common #10105

Merged
merged 2 commits into from
Feb 13, 2025
Merged

feat(autoware_motion_utils)!: port to autoware.core/common #10105

merged 2 commits into from
Feb 13, 2025

Conversation

sasakisasaki
Copy link
Contributor

@sasakisasaki sasakisasaki commented Feb 12, 2025 •
edited
Loading

Description

This PR is for porting a module from autoware.universe/common/autoware_motion_utils to autoware.core/common/autoware_motion_utils

WARNING: This PR MUST BE MERGED BY FOLLOWING STEPS:

Related links

How was this PR tested?

autoware.universe side

Ongoing => Done as this result!!!

autoware.core side

mkdir src
vcs import src < build_depends.repos
rosdep install -y --from-paths . --ignore-src --rosdistro $ROS_DISTRO
colcon build --base-paths . --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release

Notes for reviewers

Please do not approve until the preparation for merge written in the Description is not done yet.

Interface changes

None.

Effects on system behavior

The autoware_motion_utils is no longer available from the autoware.universe, but available via autoware.core

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Feb 12, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@sasakisasaki sasakisasaki mentioned this pull request Feb 12, 2025
Merged
@sasakisasaki sasakisasaki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 12, 2025
@sasakisasaki sasakisasaki marked this pull request as ready for review February 13, 2025 00:18
@kosuke55
Copy link
Contributor

@sasakisasaki
could you run evaluator with autowarefoundation/autoware.core#184

@kosuke55 kosuke55 changed the title porting(autoware_motion_utils): port to autoware.core/common !porting(autoware_motion_utils): port to autoware.core/common Feb 13, 2025
@kosuke55 kosuke55 changed the title !porting(autoware_motion_utils): port to autoware.core/common porting!(autoware_motion_utils): port to autoware.core/common Feb 13, 2025
@kosuke55 kosuke55 changed the title porting!(autoware_motion_utils): port to autoware.core/common porting(autoware_motion_utils)!: port to autoware.core/common Feb 13, 2025
@kosuke55
Copy link
Contributor

fixing dependncy and remaming functions are already done here, thanks!
#10092

@sasakisasaki
Copy link
Contributor Author

@kosuke55 Thank you for checking! Now the evaluator is running here.

kosuke55
kosuke55 reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

https://evaluation.tier4.jp/evaluation/reports/85ae7055-9f93-55e0-8c97-c02b2c96bbf3?project_id=prd_jt

@kosuke55 kosuke55 changed the title porting(autoware_motion_utils)!: port to autoware.core/common port(autoware_motion_utils)!: port to autoware.core/common Feb 13, 2025
@kosuke55 kosuke55 changed the title port(autoware_motion_utils)!: port to autoware.core/common feat(autoware_motion_utils)!: port to autoware.core/common Feb 13, 2025
@kosuke55
Copy link
Contributor

changed PR title

  • add !
  • porting -> feat

image

@mitsudome-r mitsudome-r merged commit 02733e7 into autowarefoundation:main Feb 13, 2025
30 of 32 checks passed
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosuke55 kosuke55 kosuke55 approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Software Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sasakisasaki @kosuke55 @mitsudome-r