feat: add common interface tools test #5815
Conversation
shulanbushangshu
requested review from
isamu-takagi,
tkhmy and
yabuta
as code owners
github-actions
bot
added
the
component:common
shulanbushangshu
added
the
run:build-and-test-differential
| <depend>tier4_system_msgs</depend> | ||
| <depend>yaml_cpp_vendor</depend> | ||
|
|
||
| <test_depend>ament_cmake_ros</test_depend> |
There was a problem hiding this comment.
This package uses ament_cmake_auto, so ament_cmake_ros is not needed if you use ament_auto_add_gtest. instead of ament_add_ros_isolated_gtest.
| @@ -0,0 +1,63 @@ | |||
| // Copyright 2023 TIER IV, Inc. | |||
There was a problem hiding this comment.
| // Copyright 2023 TIER IV, Inc. | |
| // Copyright 2023 The Autoware Contributors |
There was a problem hiding this comment.
This is updated and applied.
common/component_interface_tools/test/test_service_log_checker.cpp
Outdated
Show resolved
Hide resolved
shulanbushangshu
force-pushed
the
comm_tools
branch
from
cefdb57 to
0f69c40
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. |
|
@shulanbushangshu could you rebase this to the latest main? |
shulanbushangshu
force-pushed
the
comm_tools
branch
from
d6fbd39 to
01944ef
Compare
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
shulanbushangshu
force-pushed
the
comm_tools
branch
7 times, most recently
from
b70046c to
dd6dacc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5815 +/- ##
=======================================
Coverage 28.30% 28.30%
=======================================
Files 1484 1484
Lines 111090 111090
Branches 43151 43166 +15
=======================================
+ Hits 31441 31449 +8
+ Misses 76631 76623 -8
Partials 3018 3018
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It is rebased |
| @@ -17,8 +18,17 @@ | |||
| <depend>tier4_system_msgs</depend> | |||
| <depend>yaml_cpp_vendor</depend> | |||
|
|
|||
| <test_depend>ament_cmake_ros</test_depend> | |||
There was a problem hiding this comment.
| <test_depend>ament_cmake_ros</test_depend> | |
| <test_depend>ament_cmake_ros</test_depend> |
It seems that this is not required.
- Explained here: feat: add common interface tools test #5815 (comment)
| // limitations under the License. | ||
| #include "service_log_checker.hpp" | ||
|
|
||
| #include <ament_index_cpp/get_package_share_directory.hpp> |
There was a problem hiding this comment.
| #include <ament_index_cpp/get_package_share_directory.hpp> |
This is not used in the file.
| #include <rclcpp_components/register_node_macro.hpp> | ||
|
|
||
| #include <gtest/gtest.h> | ||
| #include <yaml-cpp/yaml.h> |
There was a problem hiding this comment.
| #include <yaml-cpp/yaml.h> |
This is not used in the file.
|
|
||
| #include <ament_index_cpp/get_package_share_directory.hpp> | ||
| #include <rclcpp/node_options.hpp> | ||
| #include <rclcpp_components/register_node_macro.hpp> |
There was a problem hiding this comment.
| #include <rclcpp_components/register_node_macro.hpp> |
This is not used in the file.
shulanbushangshu
force-pushed
the
comm_tools
branch
from
1b99683 to
1def039
Compare
shulanbushangshu
force-pushed
the
comm_tools
branch
from
160e58d to
282accc
Compare
|
Remove the unused head file.@xmfcx |
Signed-off-by: jack.song <[email protected]>
Signed-off-by: jack.song <[email protected]>
Signed-off-by: jack.song <[email protected]>
Signed-off-by: jack.song <[email protected]>
Signed-off-by: jack.song <[email protected]>
Signed-off-by: jack.song <[email protected]>
Signed-off-by: jack.song <[email protected]>
Signed-off-by: jack.song <[email protected]>
Signed-off-by: jack.song <[email protected]>
Description
add common interface toold test
Tests performed
add common interface toold test
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.