Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ndt_scan_matcher): detect loss PCD #6735

Closed

Conversation

anhnv3991
Copy link
Contributor

@anhnv3991 anhnv3991 commented Apr 3, 2024

Description

In map update module, add a timeout period (currently 10 msec) when wait for pcd loader client. After the timeout period, if there is no response from the client, output a warning message and drop the update.

Tests performed

Not applicable.

Effects on system behavior

None.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: anhnv3991 <[email protected]>
@github-actions github-actions bot added component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) labels Apr 3, 2024
@anhnv3991
Copy link
Contributor Author

anhnv3991 commented Apr 3, 2024

@Motsu-san @YamatoAndo @SakodaShintaro I made a draft here to discuss the functionalities of this PR. This PR is made for the task "Detect PCD Map not input".
My idea is quite simple: in NDT scan matcher, to detect if there are something wrong with the maps when dynamic loading maps, the following steps are performed in map update module.

  1. On start-up, map_update_module sends a request to the pcd loader client to request the PCD metadata. After that, map_update_module carries a copy of the PCD metadata.
  2. When dynamic load maps, map_update_module sends a request to the pcd loader client (as usual). While waiting for the response, map_update_module computes the list of maps to add/remove by itself (similar to the DifferentialMapLoaderModule::differentialAreaLoad). This process should be lightweight, and since it overlaps with the wait for response from the client, it should produces no significant latency at all.
  3. After receiving a response from the pcd loader client, we compare the list of maps to add/remove by map_update_module with the response from the client. From this comparison, we can detect the loss of PCDs.

Could you guys please let me know your thought on this implementation?

anhnv3991 and others added 25 commits April 5, 2024 08:46
Signed-off-by: anhnv3991 <[email protected]>
* docs(lane_change): update documentation

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* update validity check flow chart

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* explanation for the valid paths

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Add prerequisite in the requirement

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* update diagram

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Edit the parameters

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Explaining lane expansion

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* fix lane expansion document

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…arating for each object (autowarefoundation#6681)

* feat(perception_online_evaluator): unify debug markers instead of separating for each object

Signed-off-by: kosuke55 <[email protected]>

* fix for

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
…hs (autowarefoundation#6721)

* add validation check to prevent over cropped paths

Signed-off-by: Daniel Sanchez <[email protected]>

* use constexpr for magic number

Signed-off-by: Daniel Sanchez <[email protected]>

* make the threshold a param

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
…foundation#6704)

* feat(obstacle_avoidance_planner): sanitize reference points

Signed-off-by: Daniel Sanchez <[email protected]>

* bugfix, first point was excluded

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
…alization (autowarefoundation#6723)

Added "used_defined_initial_pose" to dummy localization

Signed-off-by: Shintaro Sakoda <[email protected]>
…UI (autowarefoundation#6717)

feat: add GUI for static centerline optimizer

Signed-off-by: Takayuki Murooka <[email protected]>
…ate recomputation (autowarefoundation#6706)

* fix: mot debug timer, full set of timings

Signed-off-by: Taekjin LEE <[email protected]>

* fix: reduce timers, rename topics

Signed-off-by: Taekjin LEE <[email protected]>

* fix: separate debugger

Signed-off-by: Taekjin LEE <[email protected]>

* chore: fix comments

Signed-off-by: Taekjin LEE <[email protected]>

* fix: fix stamp initialization, remove unused function

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
…utowarefoundation#6701)

* feat(object_recognition_utils): check input polygon on IoU calculations

Signed-off-by: Taekjin LEE <[email protected]>

* fix: MIN_AREA close to the epsilon of float 1e-6

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
…map (autowarefoundation#6727)

* fix(static_centerline_optimizer): fix lat/lon value of generated LL2 map

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
…tion#6561)

* fix(lane_change): check prepare phase in intersection

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Add new parameter, also create function

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Rename parameters

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* fix spell check

* fix config file

Signed-off-by: Zulfaqar Azmi <[email protected]>

* call the function check_prepare_phase only once

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* add parameter description in README

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* minor refactoring

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Doxygen description

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: Zulfaqar Azmi <[email protected]>
…6729)

chore(goal_planner): delete comments

Signed-off-by: kosuke55 <[email protected]>
…utowarefoundation#5021)

* add remote

* feat(global_parameter_loader): add gtest of global-parameter-loader

Signed-off-by: Cynthia Liu <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Cynthia Liu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
…n#6705)

* rework parameters

Signed-off-by: oguzkaganozt <[email protected]>

* .

Signed-off-by: oguzkaganozt <[email protected]>

* .

Signed-off-by: oguzkaganozt <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: oguzkaganozt <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…oundation#6733)

* fix: hazard status converter

Signed-off-by: Takagi, Isamu <[email protected]>

* fix: topic name and modes

Signed-off-by: Takagi, Isamu <[email protected]>

* fix check target mode

Signed-off-by: Takagi, Isamu <[email protected]>

* fix message type

Signed-off-by: Takagi, Isamu <[email protected]>

* Revert "fix check target mode"

This reverts commit 8b190b7.

---------

Signed-off-by: Takagi, Isamu <[email protected]>
…obstacle pointcloud is empty (autowarefoundation#6684)

* feat: skip validation when obstacle pointcloud is empty

Signed-off-by: yoshiri <[email protected]>

* fix: remove mistakenly unremoved line

Signed-off-by: yoshiri <[email protected]>

---------

Signed-off-by: yoshiri <[email protected]>
…arefoundation#6726)

* feat(lane_change): check prepare phase in turn direction lanes

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Doxygen comment

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* Add config

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

* fix comments by the reviewer

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
Signed-off-by: anhnv3991 <[email protected]>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) and removed component:map Map creation, storage, and loading. (auto-assigned) labels Apr 5, 2024
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Apr 5, 2024
@anhnv3991 anhnv3991 closed this Apr 5, 2024
@anhnv3991 anhnv3991 deleted the feature/detect_loss_pcd branch April 5, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.