-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(autoware_mpc_lateral_controller): fix formula description in vehicle_model_bicycle_kinematics.hpp #8971
chore(autoware_mpc_lateral_controller): fix formula description in vehicle_model_bicycle_kinematics.hpp #8971
Conversation
Signed-off-by: Autumn60 <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8971 +/- ##
=======================================
Coverage 29.76% 29.77%
=======================================
Files 1444 1443 -1
Lines 108686 108701 +15
Branches 42664 42666 +2
=======================================
+ Hits 32352 32364 +12
- Misses 73150 73151 +1
- Partials 3184 3186 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This pull request has been automatically marked as stale because it has not had recent activity. |
…hicle_model_bicycle_kinematics.hpp (autowarefoundation#8971) fix formula description in vehicle_model_bicycle_kinematics.hpp Signed-off-by: Autumn60 <[email protected]>
Description
Fixed a mathematical formula described in
vehicle_model_bicycle_kinematics.hpp
that did not match the implementation invehicle_model_bicycle_kinematics.cpp
.autoware.universe/control/autoware_mpc_lateral_controller/src/vehicle_model/vehicle_model_bicycle_kinematics.cpp
Lines 46 to 56 in d10c4c2
Related links
None.
How was this PR tested?
None.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.