Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_mpc_lateral_controller): fix formula description in vehicle_model_bicycle_kinematics.hpp #8971

Merged
merged 7 commits into from
Dec 21, 2024

Conversation

Autumn60
Copy link
Contributor

@Autumn60 Autumn60 commented Sep 26, 2024

Description

Fixed a mathematical formula described in vehicle_model_bicycle_kinematics.hpp that did not match the implementation in vehicle_model_bicycle_kinematics.cpp.

a_d << 0.0, velocity, 0.0, 0.0, 0.0, velocity / m_wheelbase * cos_delta_r_squared_inv, 0.0, 0.0,
-1.0 / m_steer_tau;
b_d << 0.0, 0.0, 1.0 / m_steer_tau;
c_d << 1.0, 0.0, 0.0, 0.0, 1.0, 0.0;
w_d << 0.0,
-velocity * m_curvature +
velocity / m_wheelbase * (tan(delta_r) - delta_r * cos_delta_r_squared_inv),
0.0;

image

Related links

None.

How was this PR tested?

None.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Sep 26, 2024
Copy link

github-actions bot commented Sep 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Autumn60 Autumn60 marked this pull request as ready for review September 26, 2024 11:19
@Autumn60 Autumn60 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 30, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.77%. Comparing base (ddfacd3) to head (1a24b13).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8971   +/-   ##
=======================================
  Coverage   29.76%   29.77%           
=======================================
  Files        1444     1443    -1     
  Lines      108686   108701   +15     
  Branches    42664    42666    +2     
=======================================
+ Hits        32352    32364   +12     
- Misses      73150    73151    +1     
- Partials     3184     3186    +2     
Flag Coverage Δ *Carryforward flag
differential 33.63% <ø> (?)
total 29.77% <ø> (+0.01%) ⬆️ Carriedforward from 5ac4823

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

stale bot commented Dec 18, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Dec 18, 2024
@Autumn60 Autumn60 enabled auto-merge (squash) December 21, 2024 13:29
@Autumn60 Autumn60 merged commit 4d529ba into autowarefoundation:main Dec 21, 2024
33 checks passed
@Autumn60 Autumn60 deleted the chore/mpc/fix_description branch December 21, 2024 13:54
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Dec 25, 2024
…hicle_model_bicycle_kinematics.hpp (autowarefoundation#8971)

fix formula description in vehicle_model_bicycle_kinematics.hpp

Signed-off-by: Autumn60 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants