refactor(autoware_behavior_velocity_stop_line_module): refactor and test #9424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
satoshi-ota
reviewed
Nov 22, 2024
...ng/behavior_velocity_planner/autoware_behavior_velocity_stop_line_module/test/test_scene.cpp
Outdated
Show resolved
Hide resolved
satoshi-ota
reviewed
Nov 22, 2024
|
|
||
| break; | ||
| } | ||
| std::pair<double, std::optional<double>> StopLineModule::getEgoAndStopPoint( |
satoshi-ota
reviewed
Nov 22, 2024
|
|
||
| private: | ||
| std::shared_ptr<const rclcpp::Time> stopped_time_; | ||
| void updateStateAndStoppedTime( |
yhisaki
added
the
run:build-and-test-differential
yhisaki
requested review from
kyoichi-sugahara,
soblin,
TakaHoribe and
zulfaqar-azmi-t4
as code owners
github-actions
bot
added
the
component:common
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9424 +/- ##
==========================================
+ Coverage 29.47% 29.50% +0.03%
==========================================
Files 1440 1446 +6
Lines 108556 108569 +13
Branches 41499 41476 -23
==========================================
+ Hits 32001 32038 +37
+ Misses 73443 73411 -32
- Partials 3112 3120 +8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
common/autoware_test_utils/config/test_behavior_velocity_planner.param.yaml
Outdated
Show resolved
Hide resolved
kyoichi-sugahara
approved these changes
Nov 25, 2024
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
yhisaki
force-pushed
the
test-and-refactor-stop_line
branch
from
edd0697 to
a868a23
Compare
github-actions
bot
removed
the
component:common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
Remove
createDebugMarkerArrayFunctionI have removed the
createDebugMarkerArrayfunction in this PR. I think this function is no longer used and when I test this function, it throws anstd::out_of_rangeexception.Prevented transition from
STARTstate toAPPROACHstateSee this conversation.
Refactor
modifyPathVelocityRefactoring
modifyPathVelocityeliminates complexity and makes it unit-testable.Test
Coverage is low, but tests what should be essentially tested (speed modification and state transitions).
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.