Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(autoware_behavior_velocity_planner_common): refactor and test autoware_behavior_velocity_planner_common #9551

Merged
merged 7 commits into from
Dec 5, 2024

Conversation

yhisaki
Copy link
Contributor

@yhisaki yhisaki commented Dec 3, 2024

Description

Refactor code and add unit test.

Screenshot from 2024-12-03 19-28-28

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

…toware_behavior_velocity_planner_common

Signed-off-by: Y.Hisaki <[email protected]>
@yhisaki yhisaki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 47.82609% with 24 lines in your changes missing coverage. Please review.

Project coverage is 29.61%. Comparing base (cf0266e) to head (1b9164d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...avior_velocity_planner_common/src/planner_data.cpp 39.13% 13 Missing and 1 partial ⚠️
...r_velocity_planner_common/src/utilization/util.cpp 61.53% 4 Missing and 1 partial ⚠️
...ocity_planner_common/utilization/state_machine.hpp 0.00% 2 Missing ⚠️
...r_common/src/utilization/boost_geometry_helper.cpp 50.00% 2 Missing ⚠️
...velocity_planner_common/scene_module_interface.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9551      +/-   ##
==========================================
+ Coverage   29.50%   29.61%   +0.10%     
==========================================
  Files        1445     1451       +6     
  Lines      108571   108611      +40     
  Branches    41425    41430       +5     
==========================================
+ Hits        32037    32162     +125     
+ Misses      73412    73314      -98     
- Partials     3122     3135      +13     
Flag Coverage Δ *Carryforward flag
differential 24.53% <47.82%> (?)
total 29.52% <ø> (+0.01%) ⬆️ Carriedforward from e75bbbc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Y.Hisaki <[email protected]>
@yhisaki yhisaki enabled auto-merge (squash) December 5, 2024 09:05
Signed-off-by: Y.Hisaki <[email protected]>
@yhisaki yhisaki disabled auto-merge December 5, 2024 09:24
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
@yhisaki yhisaki merged commit 63cfff8 into autowarefoundation:main Dec 5, 2024
27 checks passed
@yhisaki yhisaki deleted the test-bvp_common branch February 5, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants