Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_geography_utils)!: move autoware_geography_utils to autoware.core #9554

Merged

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Dec 3, 2024

Description

We are porting autoware_geography_utils to autoware.core, and this PR removes the package from autoware.universe.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that the package was cut and pasted only with the following modifications:

  • changelog.rst
  • package.xml

Source:

Target:

This should not break any existing configuration as long as we also make sure the autoware main repo points to the correct versions of core and universe.

@xmfcx xmfcx added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 4, 2024
@xmfcx xmfcx force-pushed the port-geography-utils branch from aa8d4b0 to 6b4995e Compare December 5, 2024 13:09
@xmfcx
Copy link
Contributor

xmfcx commented Dec 5, 2024

I've rebased this to latest main.

Because "include what you use" pr has modified file, it needed manual rebasing.

But in the end it is just deleting these files, so nothing really changed.

@mitsudome-r
Copy link
Member Author

@xmfcx Thanks!

@mitsudome-r mitsudome-r merged commit 8cf0bc9 into autowarefoundation:main Dec 5, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants