-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(pre-commit): update cpplint to 2.0.0 #9557
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
20d5ed3
to
d918f2f
Compare
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
efde176
to
2288373
Compare
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9557 +/- ##
==========================================
- Coverage 29.50% 29.50% -0.01%
==========================================
Files 1445 1450 +5
Lines 108571 108607 +36
Branches 41420 41423 +3
==========================================
+ Hits 32037 32042 +5
- Misses 73412 73443 +31
Partials 3122 3122
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I've updated the description above. Now I will proceed merging. Thanks @mitsudome-r -san! |
Summary
CPPLINT.cfg changes
filter=-build/c++17
addedhttps://google.github.io/styleguide/cppguide.html#Disallowed_Stdlib
https://github.com/cpplint/cpplint/blob/f4363d7fc0d5f38c4fd41b658e069e96583da0d5/cpplint.py#L6487
Since we are allowing this, I added it to the ignored lints.
filter=-whitespace/newline
addedIt was clashing with clang-format for one liner function definitions within
if()
parantheses.Casting updates
Applied
static_cast
andreinterpret_cast
in suitable places instead of raw C style casting.A mis-linting avoidance:
Include what you use
In 2 more files, added headers directly used within those files.
Rest were added with large scale PRs yesterday.