Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pre-commit): update cpplint to 2.0.0 #9557

Merged
merged 6 commits into from
Dec 5, 2024
Merged

ci(pre-commit): update cpplint to 2.0.0 #9557

merged 6 commits into from
Dec 5, 2024

Conversation

awf-autoware-bot[bot]
Copy link
Contributor

@awf-autoware-bot awf-autoware-bot bot commented Dec 3, 2024

Summary

CPPLINT.cfg changes

filter=-build/c++17 added

https://google.github.io/styleguide/cppguide.html#Disallowed_Stdlib

As with Boost, some modern C++ library functionality encourages coding practices that hamper readability—for example by removing checked redundancy (such as type names) that may be helpful to readers, or by encouraging template metaprogramming. Other extensions duplicate functionality available through existing mechanisms, which may lead to confusion and conversion costs.

Decision:

The following C++ standard library features may not be used:

  • Compile-time rational numbers (<ratio>), because of concerns that it's tied to a more template-heavy interface style.
  • The <cfenv> and <fenv.h> headers, because many compilers do not support those features reliably.
  • The <filesystem> header, which does not have sufficient support for testing, and suffers from inherent security vulnerabilities.

https://github.com/cpplint/cpplint/blob/f4363d7fc0d5f38c4fd41b658e069e96583da0d5/cpplint.py#L6487

Since we are allowing this, I added it to the ignored lints.

filter=-whitespace/newline added

It was clashing with clang-format for one liner function definitions within if() parantheses.

Casting updates

Applied static_cast and reinterpret_cast in suitable places instead of raw C style casting.

A mis-linting avoidance:

Include what you use

In 2 more files, added headers directly used within those files.
Rest were added with large scale PRs yesterday.

@awf-autoware-bot awf-autoware-bot bot added tag:bot Bot-related tasks. (auto-assigned) tag:pre-commit-autoupdate labels Dec 3, 2024
@awf-autoware-bot awf-autoware-bot bot enabled auto-merge (squash) December 3, 2024 17:52
Copy link

github-actions bot commented Dec 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@awf-autoware-bot awf-autoware-bot bot force-pushed the pre-commit-autoupdate branch from 20d5ed3 to d918f2f Compare December 4, 2024 18:22
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Dec 4, 2024
@github-actions github-actions bot removed component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) tag:require-cuda-build-and-test labels Dec 5, 2024
@xmfcx xmfcx disabled auto-merge December 5, 2024 12:43
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@awf-autoware-bot awf-autoware-bot bot force-pushed the pre-commit-autoupdate branch from efde176 to 2288373 Compare December 5, 2024 13:38
xmfcx added 3 commits December 5, 2024 16:43
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) tag:require-cuda-build-and-test labels Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 29.50%. Comparing base (1aba360) to head (094842d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
..._image_projection_based_fusion/src/fusion_node.cpp 0.00% 14 Missing ⚠️
...em/system_monitor/reader/hdd_reader/hdd_reader.cpp 0.00% 9 Missing ⚠️
...sed_fusion/src/roi_detected_object_fusion/node.cpp 0.00% 6 Missing ⚠️
...toware_pure_pursuit_core/autoware_pure_pursuit.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9557      +/-   ##
==========================================
- Coverage   29.50%   29.50%   -0.01%     
==========================================
  Files        1445     1450       +5     
  Lines      108571   108607      +36     
  Branches    41420    41423       +3     
==========================================
+ Hits        32037    32042       +5     
- Misses      73412    73443      +31     
  Partials     3122     3122              
Flag Coverage Δ *Carryforward flag
differential 30.64% <0.00%> (?)
total 29.51% <ø> (+<0.01%) ⬆️ Carriedforward from 1aba360

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx
Copy link
Contributor

xmfcx commented Dec 5, 2024

I've updated the description above.

Now I will proceed merging. Thanks @mitsudome-r -san!

@xmfcx xmfcx merged commit 53a960e into main Dec 5, 2024
34 of 36 checks passed
@xmfcx xmfcx deleted the pre-commit-autoupdate branch December 5, 2024 15:27
@xmfcx xmfcx changed the title ci(pre-commit): autoupdate ci(pre-commit): update cpplint to 2.0.0 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:bot Bot-related tasks. (auto-assigned) tag:pre-commit-autoupdate tag:require-cuda-build-and-test type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants