Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(out_of_lane): add option to use stop lines defined in the vector map #9584

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Dec 6, 2024

Description

Add an option to the out_of_lane module allowing the use of better stop positions calculated from the stop lines defined in the map.

Related links

Launch PR: autowarefoundation/autoware_launch#1259

How was this PR tested?

Psim
Evaluator (TIER IV INTERNAL LINK): https://evaluation.tier4.jp/evaluation/reports/5ff82fd6-da0a-53b0-9880-517f1140f22c?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
Added use_map_stop_lines bool true if true, try to stop at stop lines defined in the vector map

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem force-pushed the feat/out_of_lane-stop_lines-pilot_auto branch from 0eebb14 to 1339c02 Compare December 6, 2024 12:08
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 26.47059% with 75 lines in your changes missing coverage. Please review.

Project coverage is 29.41%. Comparing base (a24a335) to head (1630eb1).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...city_out_of_lane_module/src/out_of_lane_module.cpp 28.88% 24 Missing and 8 partials ⚠️
...t_of_lane_module/src/calculate_slowdown_points.cpp 11.53% 22 Missing and 1 partial ⚠️
...ocity_planner_common_universe/src/planner_data.cpp 36.66% 17 Missing and 2 partials ⚠️
..._velocity_planner_common_universe/planner_data.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9584      +/-   ##
==========================================
- Coverage   29.41%   29.41%   -0.01%     
==========================================
  Files        1419     1423       +4     
  Lines      107507   107581      +74     
  Branches    42545    42560      +15     
==========================================
+ Hits        31624    31645      +21     
- Misses      72513    72566      +53     
  Partials     3370     3370              
Flag Coverage Δ *Carryforward flag
differential 18.85% <26.47%> (?)
total 29.42% <ø> (+<0.01%) ⬆️ Carriedforward from a24a335

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem marked this pull request as ready for review December 6, 2024 22:17
@maxime-clem maxime-clem requested a review from mkquda December 6, 2024 23:28
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Dec 13, 2024
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-stop_lines-pilot_auto branch from 29ed97b to fe4820b Compare January 14, 2025 08:53
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-stop_lines-pilot_auto branch from fe4820b to ff00e0b Compare January 22, 2025 06:58
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
Signed-off-by: Maxime CLEMENT <[email protected]>
@maxime-clem maxime-clem force-pushed the feat/out_of_lane-stop_lines-pilot_auto branch from ff00e0b to e15e692 Compare January 22, 2025 09:52
Signed-off-by: Maxime CLEMENT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants