Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_motion_utils): remove clang compiler error #9713

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Dec 23, 2024

Description

Fixed clang compiler error

--- stderr: autoware_motion_utils                                
/home/veqcc/work/autoware/src/universe/autoware.universe/common/autoware_motion_utils/test/src/trajectory/benchmark_calcLateralOffset.cpp:29:18: error: unused variable 'epsilon' [-Werror,-Wunused-const-variable]
constexpr double epsilon = 1e-6;
                 ^
1 error generated.
gmake[2]: *** [CMakeFiles/test_autoware_motion_utils.dir/build.make:132: CMakeFiles/test_autoware_motion_utils.dir/test/src/trajectory/benchmark_calcLateralOffset.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:185: CMakeFiles/test_autoware_motion_utils.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2

Related links

Parent Issue:

  • Link

How was this PR tested?

build and test

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@veqcc veqcc self-assigned this Dec 23, 2024
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 23, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 23, 2024
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 👍

@satoshi-ota satoshi-ota enabled auto-merge (squash) December 23, 2024 02:44
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.78%. Comparing base (ddfacd3) to head (00aedb4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9713      +/-   ##
==========================================
+ Coverage   29.76%   29.78%   +0.02%     
==========================================
  Files        1444     1445       +1     
  Lines      108686   108706      +20     
  Branches    42664    42666       +2     
==========================================
+ Hits        32352    32383      +31     
+ Misses      73150    73135      -15     
- Partials     3184     3188       +4     
Flag Coverage Δ *Carryforward flag
differential 32.05% <ø> (?)
total 29.77% <ø> (+<0.01%) ⬆️ Carriedforward from ddfacd3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota merged commit 6a749f9 into autowarefoundation:main Dec 23, 2024
43 of 48 checks passed
@veqcc veqcc deleted the fix/autoware_motion_utils_compiler_error branch December 23, 2024 03:55
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants