-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lidar_centerpoint, pointpainting): add diag publisher for max voxel size #9720
feat(lidar_centerpoint, pointpainting): add diag publisher for max voxel size #9720
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
7cd4111
to
d13ae2c
Compare
…xel size Signed-off-by: kminoda <[email protected]>
d13ae2c
to
190bcb6
Compare
6f0b47b
to
ede9a66
Compare
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9720 +/- ##
==========================================
+ Coverage 29.59% 29.60% +0.01%
==========================================
Files 1451 1451
Lines 108919 108472 -447
Branches 42597 42539 -58
==========================================
- Hits 32232 32111 -121
+ Misses 73589 73203 -386
- Partials 3098 3158 +60
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed lidar_centerpoint
output /diagnostics
topic as desired
Tested on internal rosbag with default max_voxel_size: 40000
~/autoware$ ros2 topic echo /diagnostics
header:
stamp:
sec: 1706598335
nanosec: 955758848
frame_id: ''
status:
- level: "\0"
name: 'lidar_centerpoint: centerpoint_trt'
message: OK
hardware_id: lidar_centerpoint
values:
- key: is_num_pillars_within_range
value: 'True'
---
Tested with max_voxel_size: 400
~/autoware$ ros2 topic echo /diagnostics
header:
stamp:
sec: 1706598306
nanosec: 555616000
frame_id: ''
status:
- level: "\x01"
name: 'lidar_centerpoint: centerpoint_trt'
message: 'CenterPointTRT::detect: The actual number of pillars exceeds its maximum value, which may limit the detection performance.'
hardware_id: lidar_centerpoint
values:
- key: is_num_pillars_within_range
value: 'False'
---
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Add diagnostics for pointpainting and centerpoint, in order to handle a case where number of voxels gets higher than the threshold.
TIER IV INTERNAL LINK
Related links
Parent Issue:
How was this PR tested?
Tested by running logging simulator
Centerpoint
![image](https://private-user-images.githubusercontent.com/44218668/398833453-c8ddd660-5b30-4332-b1a5-abbaf6c9a71e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NzcyNDgsIm5iZiI6MTczODk3Njk0OCwicGF0aCI6Ii80NDIxODY2OC8zOTg4MzM0NTMtYzhkZGQ2NjAtNWIzMC00MzMyLWIxYTUtYWJiYWY2YzlhNzFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDAxMDkwOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVlMTFjNDg0YmU3YjQyOTdiZjYwOTZkNDBjY2UwYWQ4ODkxZGU5MTg2ZjI5ZGI5OWNhYzhkZjU0MWFlYTJjYWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.hdS7JQlXOLYFmCy9Ho0ePylCPh4QcHWIwFBBEG1pIxs)
PointPainting
![image](https://private-user-images.githubusercontent.com/44218668/398833778-5bea7131-f7de-44ff-87d7-783720095ebb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NzcyNDgsIm5iZiI6MTczODk3Njk0OCwicGF0aCI6Ii80NDIxODY2OC8zOTg4MzM3NzgtNWJlYTcxMzEtZjdkZS00NGZmLTg3ZDctNzgzNzIwMDk1ZWJiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDAxMDkwOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgzMzg5NTVjNmJkZTdlZWQ5NGVkNWQxZDAzM2FkZmQ1NTQzMWE2ZTA0MzY3NDY2OTc5YzI5ZWFjNmYxODRmMDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Qyx9YD6sPWL3LDI3ObhgqFAR-_jeU89noshOpzL1SIQ)
Notes for reviewers
None.
Interface changes
Topic changes
Additions and removals
/diagnostics
diagnostic_msgs/msg/DiagnosticArray
Effects on system behavior
None.