Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lidar_centerpoint, pointpainting): add diag publisher for max voxel size #9720

Merged
merged 7 commits into from
Jan 8, 2025

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Dec 23, 2024

Description

Add diagnostics for pointpainting and centerpoint, in order to handle a case where number of voxels gets higher than the threshold.

TIER IV INTERNAL LINK

Related links

Parent Issue:

  • Link

How was this PR tested?

Tested by running logging simulator

Centerpoint
image

PointPainting
image

Notes for reviewers

None.

Interface changes

Topic changes

Additions and removals

Change type Topic Type Topic Name Message Type Description
Added Pub /diagnostics diagnostic_msgs/msg/DiagnosticArray Topic description

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) tag:require-cuda-build-and-test labels Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Dec 25, 2024
@kminoda kminoda force-pushed the feat/centerpoint/add_diag branch from 7cd4111 to d13ae2c Compare December 25, 2024 04:35
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Dec 25, 2024
@kminoda kminoda force-pushed the feat/centerpoint/add_diag branch from d13ae2c to 190bcb6 Compare December 25, 2024 04:49
@github-actions github-actions bot removed component:localization Vehicle's position determination in its environment. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Dec 25, 2024
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) labels Dec 27, 2024
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Dec 27, 2024
@kminoda kminoda force-pushed the feat/centerpoint/add_diag branch from 6f0b47b to ede9a66 Compare December 27, 2024 02:46
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:system System design and integration. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Dec 27, 2024
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 29.60%. Comparing base (ab845fb) to head (86dece2).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...ion_based_fusion/src/pointpainting_fusion/node.cpp 0.00% 13 Missing ⚠️
perception/autoware_lidar_centerpoint/src/node.cpp 0.00% 13 Missing ⚠️
...autoware_lidar_centerpoint/lib/centerpoint_trt.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9720      +/-   ##
==========================================
+ Coverage   29.59%   29.60%   +0.01%     
==========================================
  Files        1451     1451              
  Lines      108919   108472     -447     
  Branches    42597    42539      -58     
==========================================
- Hits        32232    32111     -121     
+ Misses      73589    73203     -386     
- Partials     3098     3158      +60     
Flag Coverage Δ *Carryforward flag
differential 3.48% <ø> (?)
differential-cuda 5.97% <0.00%> (?)
total 29.61% <ø> (+0.02%) ⬆️ Carriedforward from 082a53f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda kminoda marked this pull request as ready for review December 27, 2024 03:07
Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed lidar_centerpoint output /diagnostics topic as desired

Tested on internal rosbag with default max_voxel_size: 40000

~/autoware$ ros2 topic echo /diagnostics
header:
  stamp:
    sec: 1706598335
    nanosec: 955758848
  frame_id: ''
status:
- level: "\0"
  name: 'lidar_centerpoint: centerpoint_trt'
  message: OK
  hardware_id: lidar_centerpoint
  values:
  - key: is_num_pillars_within_range
    value: 'True'
---

Tested with max_voxel_size: 400

~/autoware$ ros2 topic echo /diagnostics
header:
  stamp:
    sec: 1706598306
    nanosec: 555616000
  frame_id: ''
status:
- level: "\x01"
  name: 'lidar_centerpoint: centerpoint_trt'
  message: 'CenterPointTRT::detect: The actual number of pillars exceeds its maximum value, which may limit the detection performance.'
  hardware_id: lidar_centerpoint
  values:
  - key: is_num_pillars_within_range
    value: 'False'
---

LGTM

Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same tests as Dai-san, validated through the UI

image

@kminoda kminoda merged commit 9ce874c into autowarefoundation:main Jan 8, 2025
34 checks passed
@kminoda kminoda deleted the feat/centerpoint/add_diag branch January 13, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants