Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mrm_handler): fix bugprone-branch-clone #9729

Closed
wants to merge 5 commits into from

revert

7b59903
Select commit
Loading
Failed to load commit list.
Closed

fix(mrm_handler): fix bugprone-branch-clone #9729

revert
7b59903
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Dec 26, 2024 in 53s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.19 (6.84 -> 6.65)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional mrm_handler_core.cpp: MrmHandler::publishHazardCmd

Annotations

Check warning on line 120 in system/mrm_handler/src/mrm_handler/mrm_handler_core.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

MrmHandler::publishHazardCmd has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.