feat(autoware_object_merger, autoware_tracking_object_merger): enable anonymized node names to be configurable #9733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taekjin LEE <[email protected]>
github-actions
bot
added
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
technolojin
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9733 +/- ##
==========================================
- Coverage 29.74% 29.74% -0.01%
==========================================
Files 1444 1444
Lines 108693 108706 +13
Branches 42665 42668 +3
==========================================
Hits 32336 32336
- Misses 73175 73188 +13
Partials 3182 3182
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
technolojin
requested review from
YoshiRi,
yukkysaito and
miursh
as code owners
YoshiRi
approved these changes
Dec 24, 2024
..._perception_launch/launch/object_recognition/detection/merger/camera_lidar_merger.launch.xml
Show resolved
Hide resolved
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Dec 25, 2024
… anonymized node names to be configurable (autowarefoundation#9733) feat: enable anonymized node names to be configurable Signed-off-by: Taekjin LEE <[email protected]>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Dec 25, 2024
… anonymized node names to be configurable (autowarefoundation#9733) feat: enable anonymized node names to be configurable Signed-off-by: Taekjin LEE <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the node names are anonymized, the node name changes on every launch.
The random node name introduce complexity on the node diagnostics.
This PR provides the node name variable
node_nameto be configured externally.If the node name is not set, the name will be anonymized by default.
Related links
Parent Issue:
How was this PR tested?
TIER IV INTERNAL
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.