refactor(autoware_behavior_path_start_planner_module): add data_structs.cpp and init method for StartPlannerParameters #9736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pp and init method for StartPlannerParameters Signed-off-by: Kyoichi Sugahara <[email protected]>
kyoichi-sugahara
requested review from
danielsanchezaran,
kosuke55,
soblin,
satoshi-ota,
shmpwk,
TomohitoAndo and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
soblin
approved these changes
Dec 23, 2024
kyoichi-sugahara
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9736 +/- ##
==========================================
- Coverage 29.76% 29.74% -0.03%
==========================================
Files 1444 1450 +6
Lines 108699 108715 +16
Branches 42688 42652 -36
==========================================
- Hits 32359 32340 -19
- Misses 73157 73193 +36
+ Partials 3183 3182 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
merged commit f2a4129
into
autowarefoundation:main
46 of 48 checks passed
kyoichi-sugahara
deleted the
refactor/start_plaenner/define_init_parameter_function
branch
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Dec 25, 2024
…ts.cpp and init method for StartPlannerParameters (autowarefoundation#9736) feat(autoware_behavior_path_start_planner_module): add data_structs.cpp and init method for StartPlannerParameters Signed-off-by: Kyoichi Sugahara <[email protected]>
kyoichi-sugahara
added a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Dec 25, 2024
…ts.cpp and init method for StartPlannerParameters (autowarefoundation#9736) feat(autoware_behavior_path_start_planner_module): add data_structs.cpp and init method for StartPlannerParameters Signed-off-by: Kyoichi Sugahara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the parameter initialization logic from
StartPlannerModuleManager::init()toStartPlannerParameters::init()to improve code maintainability and readability. This refactoring separates parameter handling from the manager's core functionality.As shown in this PR, the main purpose is to make it easier to define parameters when implementing unit tests.
Changes are following
data_structs.cppto CMakeLists.txtRelated links
Parent Issue:
How was this PR tested?
run psim
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.