Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traffic_light_category_merger): add new traffic_light_category_merger package #9748

Merged

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Dec 24, 2024

Description

  • Add new package to replace autoware_traffic_light_occlusion_predictor when new TLs detector can handle occlusion and it becomes unnessary.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: badai-nguyen <[email protected]>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Dec 24, 2024
Signed-off-by: badai-nguyen <[email protected]>
@badai-nguyen badai-nguyen force-pushed the feat/traffic_signal_merger branch from 6eb9e76 to c3240d9 Compare December 24, 2024 01:17
@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 28.28%. Comparing base (91c8501) to head (ed1d85c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
..._merger/src/traffic_light_category_merger_node.cpp 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9748      +/-   ##
==========================================
- Coverage   28.37%   28.28%   -0.09%     
==========================================
  Files        1485     1485              
  Lines      111087   111078       -9     
  Branches    43148    43112      -36     
==========================================
- Hits        31521    31423      -98     
+ Misses      76539    76519      -20     
- Partials     3027     3136     +109     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 28.29% <ø> (-0.09%) ⬇️ Carriedforward from 622df24

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badai-nguyen badai-nguyen added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jan 14, 2025
@badai-nguyen badai-nguyen marked this pull request as ready for review January 14, 2025 02:07
Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR.
I have the discussion item below.

  1. autoware_traffic_light_category_merger is better than autoware_traffic_light_signal_merger . Because the word signal have disappear in traffic light pipeline (ref refactor(tier4_perception_msgs): rename traffic_signal to traffic_light #6375, refactor(tier4_perception_msgs): rename traffic_signal to traffic_light tier4/tier4_autoware_msgs#112). So that name is good to avoid to confuse it.
  2. input/expect_rois and tf are not needed, because they are not used in this package.

| -------------------------- | ---------------------------------------------- | ----------------------------- |
| `input/car_signals` | tier4_perception_msgs::msg::TrafficLightArray | Car TLs classification |
| `input/pedestrian_signals` | tier4_perception_msgs::msg::TrafficLightArray | Pedestrian TLs classification |
| `input/expect_rois` | autoware_perception_msgs::TrafficLightRoiArray | expected TL ROIs |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `input/expect_rois` | autoware_perception_msgs::TrafficLightRoiArray | expected TL ROIs |
| `input/expect_rois` | tier4_perception_msgs::msg::TrafficLightRoiArray | expected TL ROIs |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MasatoSaeki
Thank you for your review!

input/expect_rois and tf are not needed, because they are not used in this package.

Yes, it was removed at the latest version. I update docs here 2930d08

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@badai-nguyen badai-nguyen changed the title feat(traffic_light_signal_merger): add new traffic_light_signal_merger package feat(traffic_light_category_merger): add new traffic_light_category_merger package Jan 23, 2025
Signed-off-by: badai-nguyen <[email protected]>
@MasatoSaeki MasatoSaeki merged commit 7f9cdb6 into autowarefoundation:main Feb 9, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:require-cuda-build-and-test type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants