Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoware_component_interface_specs_universe!): rename package #9753

Merged
merged 5 commits into from
Jan 21, 2025
Merged

feat(autoware_component_interface_specs_universe!): rename package #9753

merged 5 commits into from
Jan 21, 2025

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Dec 24, 2024 •
edited
Loading

Description

This renames the autoware_component_interface_specs package to autoware_component_interface_specs_universe.
This is for migration to Autoware Core from Universe.

Related links

Parent Issue:

Private Links:

TIER IV internal links:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) tag:require-cuda-build-and-test labels Dec 24, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 24, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r force-pushed the rename-component-interface-specs branch 2 times, most recently from 2035450 to 4a9ea2d Compare January 10, 2025 11:48
@mitsudome-r mitsudome-r changed the title feat(autoware_universe_component_interface_specs!): rename package feat(autoware_component_interface_specs_universe!): rename package Jan 14, 2025
@mitsudome-r mitsudome-r marked this pull request as ready for review January 15, 2025 05:34
@mitsudome-r mitsudome-r marked this pull request as draft January 15, 2025 05:39
@mitsudome-r mitsudome-r marked this pull request as ready for review January 15, 2025 05:41
@mitsudome-r mitsudome-r mentioned this pull request Jan 15, 2025
Merged
8 tasks
@mitsudome-r
Copy link
Member Author

This must be merged together with tier4/tier4_ad_api_adaptor#130

@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 15, 2025
@mitsudome-r mitsudome-r force-pushed the rename-component-interface-specs branch from cc9d72b to 90ac0cc Compare January 20, 2025 02:25
SakodaShintaro
SakodaShintaro approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this PR with tier4/tier4_ad_api_adaptor#130
LGTM

@codecov Codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 29.50%. Comparing base (80eb07c) to head (890e50f).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
system/autoware_default_adapi/src/vehicle.cpp 0.00% 3 Missing ⚠️
system/autoware_default_adapi/src/motion.cpp 0.00% 1 Missing ⚠️
system/autoware_default_adapi/src/perception.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9753      +/-   ##
==========================================
+ Coverage   29.45%   29.50%   +0.04%     
==========================================
  Files        1425     1426       +1     
  Lines      107854   107857       +3     
  Branches    42822    42824       +2     
==========================================
+ Hits        31772    31824      +52     
+ Misses      73018    72963      -55     
- Partials     3064     3070       +6
Flag Coverage Δ *Carryforward flag
differential 31.65% <0.00%> (?)
differential-cuda 31.35% <0.00%> (?)
total 29.45% <ø> (+<0.01%) ⬆️ Carriedforward from 90ac0cc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

isamu-takagi
isamu-takagi approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to only rename files and namespaces. Build and test are successful, so it's OK.

@mitsudome-r mitsudome-r merged commit aa840ce into autowarefoundation:main Jan 21, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakodaShintaro SakodaShintaro SakodaShintaro approved these changes

@isamu-takagi isamu-takagi isamu-takagi approved these changes

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto is a code owner

@TaikiYamada4 TaikiYamada4 Awaiting requested review from TaikiYamada4 TaikiYamada4 is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@soblin soblin Awaiting requested review from soblin soblin is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 Awaiting requested review from zulfaqar-azmi-t4 zulfaqar-azmi-t4 is a code owner

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) tag:require-cuda-build-and-test type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Software Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitsudome-r @SakodaShintaro @isamu-takagi