-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): add openadkit visualizer container #5742
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: Oguz Ozturk <[email protected]>
@youtalk @mitsudome-r Please review |
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Signed-off-by: Oguz Ozturk <[email protected]>
Could you describe how to use the visualizer container in README.md? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the splitting PRs. It became to be easier to review.
|
||
- name: Run vcs import | ||
run: | | ||
vcs import src < autoware.repos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR only copies src/simulator
so that it doesn't need this line.
vcs import src < autoware.repos |
# Extract rosdep dependencies for visualizer | ||
# hadolint ignore=SC1091 | ||
RUN source /opt/ros/"$ROS_DISTRO"/setup.bash && source /opt/autoware/setup.bash \ | ||
&& /autoware/resolve_rosdep_keys.sh /autoware/src ${ROS_DISTRO} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR needs only exec_depend
dependencies.
&& /autoware/resolve_rosdep_keys.sh /autoware/src ${ROS_DISTRO} \ | |
&& /autoware/resolve_rosdep_keys.sh /autoware/src ${ROS_DISTRO} --dependency-types=exec \ |
- name: Restore ccache | ||
uses: actions/cache/restore@v4 | ||
with: | ||
path: | | ||
root-ccache | ||
key: ccache-${{ inputs.platform }}-${{ hashFiles('src/**/*.cpp') }} | ||
restore-keys: | | ||
ccache-${{ inputs.platform }}- | ||
|
||
- name: Restore apt-get | ||
uses: actions/cache/restore@v4 | ||
with: | ||
path: | | ||
var-cache-apt | ||
key: apt-get-${{ inputs.platform }}-${{ hashFiles('src/**/package.xml') }} | ||
restore-keys: | | ||
apt-get-${{ inputs.platform }}- | ||
|
||
- name: Inject cache into docker | ||
uses: reproducible-containers/[email protected] | ||
with: | ||
cache-map: | | ||
{ | ||
"root-ccache": "/root/.ccache", | ||
"var-cache-apt": "/var/cache/apt" | ||
} | ||
skip-extraction: true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cache is meant for the Dockerfile
, so no cache is effective for Dockerfile.visualizer
.
- name: Restore ccache | |
uses: actions/cache/restore@v4 | |
with: | |
path: | | |
root-ccache | |
key: ccache-${{ inputs.platform }}-${{ hashFiles('src/**/*.cpp') }} | |
restore-keys: | | |
ccache-${{ inputs.platform }}- | |
- name: Restore apt-get | |
uses: actions/cache/restore@v4 | |
with: | |
path: | | |
var-cache-apt | |
key: apt-get-${{ inputs.platform }}-${{ hashFiles('src/**/package.xml') }} | |
restore-keys: | | |
apt-get-${{ inputs.platform }}- | |
- name: Inject cache into docker | |
uses: reproducible-containers/[email protected] | |
with: | |
cache-map: | | |
{ | |
"root-ccache": "/root/.ccache", | |
"var-cache-apt": "/var/cache/apt" | |
} | |
skip-extraction: true |
Description
To enable full development and deployment with distinct containers, a dedicated visualizer container will be beneficial. This container will include the RViz Plugins, ROS 2 message definitions both from autoware.universe and TierIV scenario simulator
Additionally, it will support VNC and NoVNC so users can visualize the RViz screen remotely.
How was this PR tested?
Same containers are used on two different demos and running well. Demos can be replicated through https://github.com/autowarefoundation/openadkit_demo.autoware/tree/planning-simviz/docker
Notes for reviewers
None.
Effects on system behavior
None.