Retain RenderMaterialInstances and RenderMeshMaterialIds from frame to frame.
#16985
+179
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to frame. This commit makes Bevy use change detection to only update `RenderMaterialInstances` and `RenderMeshMaterialIds` when meshes have been added, changed, or removed. `extract_mesh_materials`, the system that extracts these, now follows the pattern that `extract_meshes_for_gpu_building` established. This improves frame time of `many_cubes` from 3.9ms to approximately 3.1ms, which slightly surpasses the performance of Bevy 0.14.
pcwalton
added
A-Rendering
BenjaminBrienen
added
the
D-Straightforward
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes Bevy use change detection to only update
RenderMaterialInstancesandRenderMeshMaterialIdswhen meshes have been added, changed, or removed.extract_mesh_materials, the system that extracts these, now follows the pattern thatextract_meshes_for_gpu_buildingestablished.This improves frame time of
many_cubesfrom 3.9ms to approximately 3.1ms, which slightly surpasses the performance of Bevy 0.14.(Resubmitted from #16878 to clean up history.)