Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic error in loading_screen.rs #16989

Merged
merged 5 commits into from
Dec 31, 2024
Merged

Fix logic error in loading_screen.rs #16989

merged 5 commits into from
Dec 31, 2024

Conversation

BenjaminBrienen
Copy link
Contributor

Objective

Fix #16792

Solution

Fix the logic to retain loaded ones

Testing

Unable to test due to #16988

@BenjaminBrienen BenjaminBrienen self-assigned this Dec 27, 2024
@BenjaminBrienen BenjaminBrienen added C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 27, 2024
@BenjaminBrienen BenjaminBrienen changed the title fix Fix logic error in loading_screen.rs Dec 27, 2024
@MiniaczQ
Copy link
Contributor

Example appears to work correctly

@BenjaminBrienen BenjaminBrienen added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 30, 2024
@BenjaminBrienen BenjaminBrienen added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Dec 30, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 31, 2024
Merged via the queue into bevyengine:main with commit 9e4c072 Dec 31, 2024
28 checks passed
@BenjaminBrienen BenjaminBrienen deleted the fix-loading-screen branch December 31, 2024 03:55
@BenjaminBrienen BenjaminBrienen removed the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rparrett rparrett rparrett approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

@BenjaminBrienen BenjaminBrienen

Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in loading_screen.rs example
4 participants
@BenjaminBrienen @MiniaczQ @rparrett @alice-i-cecile