Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix msrvs #17012

Merged
merged 5 commits into from
Dec 29, 2024
Merged

Fix msrvs #17012

merged 5 commits into from
Dec 29, 2024

Conversation

BenjaminBrienen
Copy link
Contributor

@BenjaminBrienen BenjaminBrienen commented Dec 28, 2024

Objective

The rust-versions are out of date.
Fixes #17008

Solution

Update the values

Cherry-picked from #17006 in case it is controversial

Testing

Validated locally and in #17006

@BenjaminBrienen BenjaminBrienen self-assigned this Dec 28, 2024
@BenjaminBrienen BenjaminBrienen added D-Trivial Nice and easy! A great choice to get started with Bevy A-Cross-Cutting Impacts the entire engine S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Bug An unexpected or incorrect behavior labels Dec 28, 2024
@mockersf mockersf mentioned this pull request Dec 29, 2024
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a broader question of whether or not these crates should all have a listed MSRV, but given that it currently exists it should not be wrong.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 29, 2024
@BenjaminBrienen
Copy link
Contributor Author

I can remove the one for input_focus if you want @alice-i-cecile

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 29, 2024
Merged via the queue into bevyengine:main with commit 8c34f00 Dec 29, 2024
33 checks passed
@BenjaminBrienen BenjaminBrienen deleted the fix-msrvs branch December 29, 2024 20:26
@BenjaminBrienen BenjaminBrienen removed the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Dec 29, 2024
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
# Objective

The rust-versions are out of date.
Fixes bevyengine#17008

## Solution

Update the values

Cherry-picked from bevyengine#17006 in case it is controversial

## Testing

Validated locally and in bevyengine#17006

---------

Co-authored-by: Alice Cecile <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Cross-Cutting Impacts the entire engine C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust-versions are incorrect
2 participants