Add no_std support to bevy_window
#17031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushrat011899
added
C-Feature
| @@ -134,6 +134,14 @@ impl Prepare for CompileCheckNoStdCommand { | |||
| "Please fix compiler errors in output above for bevy_state no_std compatibility.", | |||
| )); | |||
|
|
|||
| commands.push(PreparedCommand::new::<Self>( | |||
There was a problem hiding this comment.
We should probably start deduplicating this logic soon.
There was a problem hiding this comment.
Yeah @BD103 and I had a chat about this earlier today. I like the idea of moving this out into a toml, csv or some other "plain data" file format.
There was a problem hiding this comment.
I also think we're rapidly reaching a critical mass of functionality where we could replace this CI task with just an example crate instead.
There was a problem hiding this comment.
It would be nice if this could be rolled up into a loop, but the macro requires a string literal, which means no format string.
alice-i-cecile
approved these changes
Dec 30, 2024
TimJentzsch
approved these changes
Dec 30, 2024
TimJentzsch
added
S-Ready-For-Final-Review
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
auto-merge was automatically disabled
December 30, 2024 21:42
Head branch was pushed to by a user without write access
|
@alice-i-cecile just ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
no_stdBevy #15460Solution
std(default)bevy_reflect(default)libmTesting
Notes
bevy_reflectwas previously always enabled, which isn't how most other crates handle reflection. I've brought this in line with how most crates gatebevy_reflect. This is where the majority of the changes come from in this PR.