Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare_sprite_image_bind_groups refactor #17045

Merged
merged 2 commits into from
Dec 30, 2024
Merged

prepare_sprite_image_bind_groups refactor #17045

merged 2 commits into from
Dec 30, 2024

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Dec 30, 2024 •
edited
Loading

Objective

In prepare_sprite_image_bind_groups the batch_image_changed condition is checked twice but the second if-block seems unnecessary.

Solution

Queue new SpriteBatches inside the first if-block and remove the second if-block.

@ickshonpe
In prepare_sprite_image_bind_groups the batch_image_changed condi…
002cb8f 
…tion if checked twice but the second if-block seems to be unnecessary.

This PR queues new `SpriteBatch`es inside the first if block and removes the second if-block.
@ickshonpe ickshonpe added A-Rendering Drawing game state to the screen D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Code-Quality A section of code that is hard to understand or change labels Dec 30, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 30, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 30, 2024
Merged via the queue into bevyengine:main with commit 1e9f647 Dec 30, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@MalekiRe MalekiRe Awaiting requested review from MalekiRe

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ickshonpe @alice-i-cecile @BenjaminBrienen