Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the atlas_scaling field from ExtractedUiItem::Gylphs. #17047

Merged
merged 2 commits into from
Jan 1, 2025
Merged

Remove the atlas_scaling field from ExtractedUiItem::Gylphs. #17047

merged 2 commits into from
Jan 1, 2025

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Dec 30, 2024 •
edited
Loading

Objective

Remove the atlas_scaling field from ExtractedUiItem::Gylphs.

It's only ever set to Vec2::ONE. I don't remember why/if this field was ever needed, maybe it was useful before the scale factor clean up.

Migration Guide

The atlas_scaling field from ExtractedUiItem::Gylphs has been removed. This shouldn't affect any existing code as it wasn't used for anything.

@ickshonpe ickshonpe added A-Text Rendering and layout for characters C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 30, 2024
@alice-i-cecile alice-i-cecile added M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Could you add some context on what users should update when this change get released in a new version of Bevy?
It will be used to help writing the migration guide for the version. Putting it after a ## Migration Guide will help it get automatically picked up by our tooling.

@alice-i-cecile
Copy link
Member

Once there's a quick note for the migration guide this LGTM and I'll merge.

@ickshonpe ickshonpe added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Dec 31, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jan 1, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 1, 2025
Merged via the queue into bevyengine:main with commit 0141bd0 Jan 1, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Text Rendering and layout for characters C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ickshonpe @alice-i-cecile @BenjaminBrienen