Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing ValArithmeticError typo and unused variant #17597

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing ValArithmeticError typo and unused variant #17597

wants to merge 1 commit into from
+8 −14

Conversation

eckz
Copy link
Contributor

@eckz eckz commented Jan 29, 2025

Objective

  • ValArithmeticError contains a typo, and one of it's variants is not used

Solution

  • Rename NonEvaluateable::NonEvaluateable variant to NonEvaluateable::NonEvaluable.
  • Remove variant ValArithmeticError:: NonIdenticalVariants.

Testing

  • cargo run -p ci

Migration Guide

  • ValArithmeticError::NonEvaluateable has been renamed to NonEvaluateable::NonEvaluable
  • ValArithmeticError::NonIdenticalVariants has been removed

@ickshonpe ickshonpe added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 29, 2025
ickshonpe
ickshonpe approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@ickshonpe ickshonpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

crates/bevy_ui/src/geometry.rs
Comment on lines -253 to -254
#[error("the variants of the Vals don't match")]
NonIdenticalVariants,
Copy link
Contributor

@ickshonpe ickshonpe Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to have some functions that allowed arithmetic between identical variants but they were removed, leaving this behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ickshonpe ickshonpe ickshonpe approved these changes

@Carter0 Carter0 Carter0 approved these changes

Assignees
No one assigned
Labels
A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eckz @Carter0 @ickshonpe