Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing Reflect on *MeshBuilder types #17600

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Implementing Reflect on *MeshBuilder types #17600

merged 1 commit into from
Feb 3, 2025

Conversation

eckz
Copy link
Contributor

@eckz eckz commented Jan 29, 2025

Objective

  • Most of the *MeshBuilder classes are not implementing Reflect

Solution

  • Implementing Reflect for all *MeshBuilder were is possible.
  • Make sure all *MeshBuilder implements Default.
  • Adding new MeshBuildersPlugin that registers all *MeshBuilder types.

Testing

  • cargo run -p ci
  • Tested some examples like 3d_scene just in case something was broken.

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types A-Math Fundamental domain-agnostic mathematical operations S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 29, 2025
@alice-i-cecile
Copy link
Member

Interesting; why do you need Reflect on these? I didn't expect these types to be persisted much of anywhere.

@eckz
Copy link
Contributor Author

eckz commented Jan 29, 2025

The usecase was editing Meshable items, like cubes planes, etc, directly using bevy_egui_inspector.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 3, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 3, 2025
Merged via the queue into bevyengine:main with commit b978b13 Feb 3, 2025
34 checks passed
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
@eckz @mrchantey
Implementing Reflect on *MeshBuilder types (bevyengine#17600)
c37803e 
# Objective

- Most of the `*MeshBuilder` classes are not implementing `Reflect`

## Solution

- Implementing `Reflect` for all `*MeshBuilder` were is possible.
- Make sure all `*MeshBuilder` implements `Default`.
- Adding new `MeshBuildersPlugin` that registers all `*MeshBuilder`
types.

## Testing

- `cargo run -p ci`
- Tested some examples like `3d_scene` just in case something was
broken.
joshua-holmes pushed a commit to joshua-holmes/bevy that referenced this pull request Feb 5, 2025
@eckz @joshua-holmes
Implementing Reflect on *MeshBuilder types (bevyengine#17600)
7a09a9b 
# Objective

- Most of the `*MeshBuilder` classes are not implementing `Reflect`

## Solution

- Implementing `Reflect` for all `*MeshBuilder` were is possible.
- Make sure all `*MeshBuilder` implements `Default`.
- Adding new `MeshBuildersPlugin` that registers all `*MeshBuilder`
types.

## Testing

- `cargo run -p ci`
- Tested some examples like `3d_scene` just in case something was
broken.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@Carter0 Carter0 Carter0 approved these changes

Assignees
No one assigned
Labels
A-Math Fundamental domain-agnostic mathematical operations A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eckz @alice-i-cecile @Carter0