Bump to uuid 1.13.1 and enable js on wasm targets
#17689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushrat011899
added
D-Trivial
AbelToy
approved these changes
Feb 5, 2025
Bleachfuel
approved these changes
Feb 5, 2025
bushrat011899
added
the
S-Waiting-on-Author
|
The issue with |
bushrat011899
added
S-Blocked
bushrat011899
changed the title
uuid 1.13 and enable js on wasm targetsuuid 1.13.1 and enable js on wasm targets
bushrat011899
added
S-Ready-For-Final-Review
|
|
alice-i-cecile
approved these changes
Feb 5, 2025
joshua-holmes
pushed a commit
to joshua-holmes/bevy
that referenced
this pull request
Feb 5, 2025
…7689) # Objective - Fixes CI failure due to `uuid` 1.13 using the new version of `getrandom` which requires using a new API to work on Wasm. ## Solution - Based on [`uuid` 1.13 release notes](https://github.com/uuid-rs/uuid/releases/tag/1.13.0) I've enabled the `js` feature on `wasm32`. This will need to be revisited once bevyengine#17499 is up for review - Updated minimum `uuid` version to 1.13.1, which fixes a separate issue with `target_feature = atomics` on `wasm`. ## Testing - `cargo check --target wasm32-unknown-unknown`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
uuid1.13 using the new version ofgetrandomwhich requires using a new API to work on Wasm.Solution
uuid1.13 release notes I've enabled thejsfeature onwasm32. This will need to be revisited once Support for non-browserwasm#17499 is up for reviewuuidversion to 1.13.1, which fixes a separate issue withtarget_feature = atomicsonwasm.Testing
cargo check --target wasm32-unknown-unknown