Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New prefix: psskb #1398

Merged
merged 10 commits into from
Feb 13, 2025
Merged

New prefix: psskb #1398

merged 10 commits into from
Feb 13, 2025

Conversation

nalikapalayoor
Copy link
Contributor

@nalikapalayoor nalikapalayoor commented Feb 1, 2025

PSSKB uses identifiers for protein motifs for which it provides data
Pubmed: https://pubmed.ncbi.nlm.nih.gov/39876062/
Database: https://psskb.org/

@bgyori
Copy link
Contributor

bgyori commented Feb 2, 2025

Upon closer review, I am not convinced this should be a provider for UniProt and PDB. All the UniProt/PDB identifiers just link to those external resources, PSSKB doesn't actually appear to resolve these. What PSSKB provides is entries for what they call Motifs such as at https://psskb.org/motif/card/2VM6_A55_A135 (see also screenshot).

image

For practical purposes the Motif IDs could be considered unique IDs introduced and resolved by PSSKB (even though they are not completely novel in the they consist of three pieces, a PDB ID, a start marker and an end marker). Some examples here:

image

If we do this then it could be considered a new prefix.

@nalikapalayoor
Copy link
Contributor Author

There is no contact info listed anywhere on the website for the database so I put placeholders for now (so that I could lint the file). What should I do about this?

@bgyori bgyori changed the title New provider: psskb New prefix: psskb Feb 12, 2025
@bgyori bgyori added Prefix New Used in combination with prefix, metaprefix, or collection for new entries labels Feb 12, 2025
@cthoyt
Copy link
Member

cthoyt commented Feb 12, 2025

@nalikapalayoor this curation training video might be useful for you for finding contact info in the future https://www.youtube.com/watch?v=FN6JJ0oKNCU

@nalikapalayoor
Copy link
Contributor Author

@cthoyt I will look at that thank you so much!

@bgyori
Copy link
Contributor

bgyori commented Feb 12, 2025

Something got messed up with this git branch... I can help offline.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.80%. Comparing base (8950e70) to head (c630a44).
Report is 313 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
+ Coverage   42.51%   46.80%   +4.29%     
==========================================
  Files         117      118       +1     
  Lines        8327     8332       +5     
  Branches     1963     1354     -609     
==========================================
+ Hits         3540     3900     +360     
+ Misses       4582     4239     -343     
+ Partials      205      193      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bgyori bgyori merged commit ba174d0 into biopragmatics:main Feb 13, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Used in combination with prefix, metaprefix, or collection for new entries Prefix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants