fix: add rinfo to UDPHelper message event

[Luuccc]

• Added rinfo argument to message event as it was omitted.
• Added emit to 'message' event for consistency.
• Including original 'data' event for projects that expect it, as
  well as rinfo.
• Renamed data arg to msg, inline with nodejs api.

[Luuccc]

Interesting, I sort of understand why it might be best to leave this.emit('data', msg) as it was originally. Even though as I understand it, the added parameter is optional.

But I'm unsure why the Argument of type '"message"' is not assignable to parameter of type 'keyof UDPHelperEvents'.

[Julusian]

I don't think we should emit both 'data' and 'message' events. I expect that will lead to confusion from module devs questioning what the difference is and which they should use.
While our naming doesn't match the nodejs dgram, it is consistent with the TCPHelper

That typings issue is because you need to update the typescript interface here:

companion-module-base/src/helpers/udp.ts

Line 30 in cfb2a75

data: [msg: Buffer]

That line will need updating to include the new parameter with the correct type

[Luuccc]

I agree that might cause some confusion.
I've removed the emit to an external 'message' event, and I've fixed the issue with the interface

[Julusian]

This is in v1.11.2

[Luuccc]

Thanks Julian, and also for the code review. I never would've guessed it's type being dgram.RemoteInfo, I can't find a mention of it anywhere, beyond some mentions within net.js and this definition issue. Thanks again