Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rinfo to UDPHelper message event #103

Merged
merged 6 commits into from
Nov 18, 2024
Merged

fix: add rinfo to UDPHelper message event #103

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
942d204
Resolving broadcast option within UDP Helper
Luuccc Nov 5, 2024
7fc1366
Merge branch 'bitfocus:main' into main
Luuccc Nov 10, 2024
55cbc15
fix: Extended event to include rinfo
Luuccc Nov 10, 2024
6f9ae4a
Merge branch 'bitfocus:main' into main
Luuccc Nov 17, 2024
9540046
fix: Included rinfo in UDP 'message' (data) event
Luuccc Nov 17, 2024
3d001f2
Update src/helpers/udp.ts
Julusian Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/helpers/udp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export interface UDPHelperEvents {
// the socket is listening for packets
listening: []
// a packet of data has been received
data: [msg: Buffer]
data: [msg: Buffer, rinfo: dgram.RemoteInfo]

// the connection status changes
status_change: [status: UDPStatuses, message: string | undefined]
Expand Down Expand Up @@ -119,7 +119,8 @@ export class UDPHelper extends EventEmitter<UDPHelperEvents> {
this.emit('listening')
})

this.#socket.on('message', (data) => this.emit('data', data))
// Passing on rinfo to emit instead of omitting it
this.#socket.on('message', (data, rinfo) => this.emit('data', data, rinfo))

this.#missingErrorHandlerTimer = setTimeout(() => {
if (!this.#destroyed && !this.listenerCount('error')) {
Expand Down