Add ESM/CJS double-publishing #28
Conversation
| }, | ||
| "type": "commonjs", |
There was a problem hiding this comment.
I've removed explicit type, because it can actually be either ESM or CommonJS, but we can't default it to ESM, because otherwise tests break, as older TAP does not support CJS format, and older Node versions don't support ESM
|
@brianloveswords How can we proceed with this one? |
|
@kibertoad hey sorry for the delay, it's been a good many years since I've published an npm package and I didn't want to mess it up, I started refreshing myself on those instructions before I got distracted. If you're more seasoned at this, I'm happy to make you a maintainer, but I also don't wanna burden you with that if you're not interested. let me know and I'll either give you the permissions, or I'll get to it later this week! |
|
@brianloveswords I can do the publishing if you don't mind giving the access; I'm already maintaining fair amount of packages, what is one more :D |
|
@kibertoad fantastic, I've added you on npm and in GitHub. also, I did not realize it's getting this many downloads 🤯 |
|
oh yeah, your library definitely found its niche! |
|
@brianloveswords OK, after several iteration this finally works as expected. See https://arethetypeswrong.github.io/?p=buffer-crc32%401.0.0-RC9 report. |
|
@brianloveswords After this is approved and merged, we are good to release a new version. Do you think that it's time for a big 1.0.0 release? |
@kibertoad yeah, I think so! 🎉 |
|
Awesome! should I release it already? |
|
ship it! 🚢 |
|
@brianloveswords Aaaaaand it's up! |
Fixes #25
OK, that was easier than expected! I would appreciate it if you could publish a prerelease version of this to npm, so that I could test if it works as expected.