-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESM/CJS double-publishing #28
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f1b0de5
Add ESM/CJS double-publishing
kibertoad 3381144
Adjust configuration
kibertoad daa1aca
Remove redundant import
kibertoad 8b3aeb3
Do not install unbuild as a dependency to avoid breaking Node 8
kibertoad 78060e0
Merge branch 'master' into chore/esm
kibertoad 5807b36
Make arethetypeswrong happy
kibertoad 7a8551c
Remove redundant docs
kibertoad 8fc08ed
Restore original version
kibertoad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
export default { | ||
entries: ['./index.js'], | ||
rollup: { | ||
emitCJS: true, | ||
}, | ||
failOnWarn: false, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/// <reference types="node" /> | ||
|
||
/** | ||
* These definitions were written by BendingBender (https://github.com/BendingBender) | ||
*/ | ||
|
||
export = crc32; | ||
|
||
declare function crc32(input: string | Buffer, partialCrc?: Buffer | number): Buffer; | ||
|
||
declare namespace crc32 { | ||
/** | ||
* Convenience method that returns a signed int instead of a `Buffer`. | ||
* | ||
* @example | ||
* import crc32 = require('buffer-crc32'); | ||
* | ||
* // works with buffers | ||
* const buf = Buffer.from([0x00, 0x73, 0x75, 0x70, 0x20, 0x62, 0x72, 0x6f, 0x00]); | ||
* crc32.signed(buf); // -> -1805997238 | ||
*/ | ||
function signed(buffer: string | Buffer, partialCrc?: Buffer | number): number; | ||
|
||
/** | ||
* Convenience method that returns an unsigned int instead of a `Buffer`. | ||
* | ||
* @example | ||
* import crc32 = require('buffer-crc32'); | ||
* | ||
* // works with buffers | ||
* const buf = Buffer.from([0x00, 0x73, 0x75, 0x70, 0x20, 0x62, 0x72, 0x6f, 0x00]); | ||
* crc32.unsigned(buf); // -> 2488970058 | ||
*/ | ||
function unsigned(buffer: string | Buffer, partialCrc?: Buffer | number): number; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,12 +20,12 @@ | |
"type": "git", | ||
"url": "git://github.com/brianloveswords/buffer-crc32.git" | ||
}, | ||
"main": "index.js", | ||
"scripts": { | ||
"test": "tap tests/*.test.js --reporter classic", | ||
"build": "npx [email protected] && npx cpy-cli index.d.ts dist --rename=index.d.cts && npx cpy-cli index.d.ts dist --rename=index.d.mts", | ||
"prepublishOnly": "npm run build", | ||
"format": "prettier --write --log-level warn \"**/*.{json,md,js}\"" | ||
}, | ||
"type": "commonjs", | ||
"dependencies": {}, | ||
"devDependencies": { | ||
"prettier": "^3.2.4", | ||
|
@@ -36,7 +36,19 @@ | |
"node": ">=8.0.0" | ||
}, | ||
"license": "MIT", | ||
"type": "commonjs", | ||
"exports": { | ||
".": { | ||
"import": "./dist/index.mjs", | ||
"require": "./dist/index.cjs" | ||
} | ||
}, | ||
"main": "./dist/index.cjs", | ||
"types": "./index.d.ts", | ||
"files": [ | ||
"index.js" | ||
"dist", | ||
"index.d.ts", | ||
"LICENSE", | ||
"README.md" | ||
] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed explicit type, because it can actually be either ESM or CommonJS, but we can't default it to ESM, because otherwise tests break, as older TAP does not support CJS format, and older Node versions don't support ESM