refactor: User UserCreationService in self serve admin creation
#19200
+101
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
joeauyeung
commented
Feb 9, 2025
Comment on lines
-37
to
-40
| const username = slugify(parsedQuery.data.username.trim()); | ||
| const userEmail = parsedQuery.data.email_address.toLowerCase(); | ||
|
|
||
| const hashedPassword = await hashPassword(parsedQuery.data.password); |
There was a problem hiding this comment.
Move these two calls to the UserCreationService
| API_V1 @map("api_v1") | ||
| API_V2 @map("api_v2") | ||
| WEBAPP @map("webapp") | ||
| SELF_SERVE_ADMIN @map("self_serve_admin") |
There was a problem hiding this comment.
We should expand on the CreationSource to pinpoint where watchlisted users are created
3 tasks
…usercreationservice
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/10/25)1 reviewer was added to this PR based on Keith Williams's automation. |
…usercreationservice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #19150
What does this PR do?
SELF_SERVE_ADMINto creation sourceUserCreationServiceinapi/auth/setupendpointMandatory Tasks (DO NOT REMOVE)
How should this be tested?