-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: User UserCreationService
in self serve admin creation
#19200
Open
joeauyeung
wants to merge
9
commits into
create-usercreationservice-for-api
Choose a base branch
from
sys-admin-use-usercreationservice
base: create-usercreationservice-for-api
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e2e397f
Add `SELF_SERVE_ADMIN` to `CreationSource`
joeauyeung 01d1799
Add migration to add `SELF_SERVE_ADMIN` to `CreationSource`
joeauyeung 6ed93e4
Use `SELF_SERVE_ADMIN` in setup endpoint
joeauyeung d1ad56b
Self serve setup use `UserCreationService`
joeauyeung 4c70911
Type fix
joeauyeung 0465710
Add tests
joeauyeung 53e4bce
Make test more robust
joeauyeung 827c3f5
Merge branch 'create-usercreationservice-for-api' into sys-admin-use-…
joeauyeung f004337
Merge branch 'create-usercreationservice-for-api' into sys-admin-use-…
joeauyeung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
...es/prisma/migrations/20250209030127_add_self_serve_admin_to_creation_source/migration.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
-- AlterEnum | ||
ALTER TYPE "CreationSource" ADD VALUE 'self_serve_admin'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,9 +43,10 @@ enum PeriodType { | |
} | ||
|
||
enum CreationSource { | ||
API_V1 @map("api_v1") | ||
API_V2 @map("api_v2") | ||
WEBAPP @map("webapp") | ||
API_V1 @map("api_v1") | ||
API_V2 @map("api_v2") | ||
WEBAPP @map("webapp") | ||
SELF_SERVE_ADMIN @map("self_serve_admin") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should expand on the |
||
} | ||
|
||
model Host { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move these two calls to the
UserCreationService