Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Compat Matrix more comprehensive #17303

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

irvinebroque
Copy link
Contributor

No description provided.

Attempts to cover all the differences between Workers and Pages
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 files reviewed, 1 total issue(s) found.


<sup>1</sup> If you need to run a Worker script ahead of serving static assets,
we currently recommend using [Service
<sup>1</sup> For more details on which bindings are supported in remote development, [refer to the docs]((/workers/testing/local-development/#supported-resource-bindings-in-different-environments)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<sup>1</sup> For more details on which bindings are supported in remote development, [refer to the docs]((/workers/testing/local-development/#supported-resource-bindings-in-different-environments)
<sup>1</sup> For more details on which bindings are supported in remote development, [refer to the docs]((/Workers/testing/local-development/#supported-resource-bindings-in-different-environments)

Issues:

  • Style Guide - (Terms-error) Use 'Workers' instead of 'workers'.

Fix Explanation:

The term 'Workers' should be capitalized as it likely refers to a specific product or feature name, which is a common convention in technical documentation. This change aligns with the style guide's requirement for proper noun capitalization. If 'Workers' is indeed a product name, this correction is necessary to maintain consistency and clarity in the documentation. If the style guide does not currently reflect this, it may need updating to ensure all instances are treated consistently.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We updated our model to better handle this case. Should be updated soon.

Bill, Hyperlint dev

Copy link

cloudflare-workers-and-pages bot commented Oct 3, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: e600801
Status: ✅  Deploy successful!
Preview URL: https://91a26856.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://bib-compat-matrix.cloudflare-docs-7ou.pages.dev

View logs

@tanushree-sharma
Copy link
Contributor

Would be good to add a legend for the table:
✅ Supported
⏳ Coming soon
🟡 Unsupported, workaround available
❌ Unsupported

@tanushree-sharma
Copy link
Contributor

tanushree-sharma commented Oct 3, 2024

Since scope is now more broad, should we move this up for vis into the get started guides for Workers and Pages?

| [Real-time logs](/workers/observability/logs/real-time-logs/) | ✅ | ✅ |
| **Runtime APIs & Compute Models** | | |
| [Node.js Compatibility Mode](/workers/runtime-apis/nodejs/) | ✅ | ✅ |
| [Durable Objects](/durable-objects/api/) | ✅ | 🟡 <sup>7</sup> |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is DO here? Would expect this to be under bindings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A DO is a singleton Worker, as fundamental a compute primitive to the platform as a Worker. We need to stop treating it just as binding but as first-class compute primitive. Can move back to bindings for now from here but it is apples vs. oranges to other bindings.

@vy-ton re: framing, I think we have habit of bucketing DO with other bindings but feels different

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 grouping DO under Runtime APIs, DO team has #17411 (comment) to create Runtime APIs section in DO docs

@tanushree-sharma
Copy link
Contributor

SSL for SaaS + WFP would be good ones to add here. SSL for SaaS not supported for Pages (people need to use pages custom domains for this). WFP in progress for Workers (hoping to do this Q4)

@irvinebroque irvinebroque marked this pull request as ready for review October 9, 2024 16:16
@irvinebroque irvinebroque requested review from GregBrimble, WalshyDev and a team as code owners October 9, 2024 16:16
@irvinebroque
Copy link
Contributor Author

Since scope is now more broad, should we move this up for vis into the get started guides for Workers and Pages?

@tanushree-sharma maybe not in Getting Started section but yes, somewhere discoverable + I think Pages needs to explicitly link to in top-level of docs

Copy link
Collaborator

@dcpena dcpena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small punctuation edits

@irvinebroque irvinebroque merged commit 91e869f into production Oct 18, 2024
13 checks passed
@irvinebroque irvinebroque deleted the bib/compat-matrix branch October 18, 2024 16:17
we currently recommend using [Service
<sup>1</sup> For more details on which bindings are supported in remote development, [refer to the docs](/workers/testing/local-development/#supported-resource-bindings-in-different-environments).

<sup>2</sup> Similar to <sup>1</sup>, to customize the HTTP headers that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<sup>2</sup> Similar to <sup>1</sup>, to customize the HTTP headers that
<sup>2</sup> Similar to <sup>3</sup>, to customize the HTTP headers that

@@ -51,22 +64,46 @@ We plan to bridge the gaps between Workers and Pages and provide ways to migrate
| [Secrets](/workers/configuration/secrets/) | ✅ | ✅ |
| [Service bindings](/workers/runtime-apis/bindings/service-bindings/) | ✅ | ✅ |
| [Vectorize](/vectorize/get-started/intro/#3-bind-your-worker-to-your-index) | ✅ | ✅ |
| **Builds (CI/CD)** | | |
| [Monorepos](/workers/ci-cd/builds/advanced-setups/) | ✅ | ✅ |
| [Build Watch Paths](/pages/configuration/build-watch-paths/) | ❌ | ✅ |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:workers Related to Workers product size/s
Projects
None yet
Development

Successfully merging this pull request may close these issues.