Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set popup name to unique string #1474

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Set popup name to unique string #1474

merged 4 commits into from
Jan 13, 2025

Conversation

cb-jake
Copy link
Contributor

@cb-jake cb-jake commented Jan 8, 2025

Summary

Set the popup name to a unique string vs a hard coded string

How did you test your changes?

Unit tests

@cb-jake cb-jake requested a review from fan-zhang-sv January 8, 2025 23:40
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 8, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

fan-zhang-sv
fan-zhang-sv approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@fan-zhang-sv fan-zhang-sv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cb-jake cb-jake merged commit 3cd583e into master Jan 13, 2025
8 checks passed
@cb-jake cb-jake deleted the set-popup-name branch January 13, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fan-zhang-sv fan-zhang-sv fan-zhang-sv approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cb-jake @cb-heimdall @fan-zhang-sv