Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need for a knowledgebase explanation on how to handle pyproject.toml, PEP 517, and PEP 518 #1174

Open
moorepants opened this issue Oct 23, 2020 · 1 comment
Labels

Comments

@moorepants
Copy link
Contributor

Issue:

pip now uses the pyproject.toml file by default as per PEP 517 and PEP 518. But that file seems to be a bit redundant with the conda meta.yaml file. I've had to delete this file from the downloaded tarballs to get builds working and it seems many other feedstocks do the same:

https://github.com/search?q=org%3Aconda-forge+pyproject.toml&type=code

Is the best practice to delete the file? pip has -no-binary and --no-use-pep-517 (or did) but I haven't had luck with those flags combined with conda. Maybe someone else knows the best approach at dealing with pip trying to setup a build environment when it isn't needed because conda build already handles that.

Whatever the answer is, it would be good to add something to the knowledge base page about this. I can add something, but I'm not sure what should be added.


Environment (conda list):
$ conda list


Details about conda and system ( conda info ):
$ conda info

@croth1 croth1 added the Docs label Oct 25, 2020
@moorepants moorepants changed the title Need for a knowledgebase explanation on how to handle pyproject.toml, PEP 517, and PEP 158 Need for a knowledgebase explanation on how to handle pyproject.toml, PEP 517, and PEP 518 Oct 26, 2020
@moorepants
Copy link
Contributor Author

I just noticed this PR that should address this: #1540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants