Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New recipe with updated dependencies and maintainer #52

Merged
merged 6 commits into from
Nov 16, 2024

Conversation

thewchan
Copy link
Contributor

Checking to see why pip check fails

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Checking to see why pip check fails
@thewchan
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@thewchan
Copy link
Contributor Author

@hmaarrfk sorry for the ping; trying here but there's not a lot of feedback to debug why pip check is failing here...

@thewchan thewchan mentioned this pull request Nov 15, 2024
3 tasks
@hmaarrfk
Copy link

does backporting uqfoundation/multiprocess#197 help

@thewchan
Copy link
Contributor Author

@hmaarrfk we can try; using a patch?

@hmaarrfk
Copy link

yes, you can get the patch by going to the url and adding a .patch at the end

@thewchan
Copy link
Contributor Author

yes, you can get the patch by going to the url and adding a .patch at the end

@hmaarrfk I didn't know this! I did this the long way this time but will note for future reference

@thewchan
Copy link
Contributor Author

@conda-forge-admin, please rerender

@thewchan
Copy link
Contributor Author

@hmaarrfk I don't think I got it to work?

@hmaarrfk
Copy link

No you did not get it to work.

It helps to run things in debug mode where you can see that the setup.cfg file uploaded to pypi.org is wrong.

I think that is what the patch tries to resolve.

Instead, I had to delete it:
#54

@thewchan
Copy link
Contributor Author

got it, I can close this one in favor of yours if that helps

@hmaarrfk
Copy link

No. I explicitly said I don't want that in mine. You should take ownership

@thewchan
Copy link
Contributor Author

@jschueller and @synapticarbors thanks to @hmaarrfk's help go this to work with pip check; this should alleviate many downstream woes (we hope anyway). Appreciate a review and merge 🙏

@synapticarbors synapticarbors merged commit d39c561 into conda-forge:main Nov 16, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants